Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler flag to disable the "implicit interface" feature. #7493

Closed
vicuna opened this issue Feb 24, 2017 · 4 comments · Fixed by #9407
Closed

Compiler flag to disable the "implicit interface" feature. #7493

vicuna opened this issue Feb 24, 2017 · 4 comments · Fixed by #9407

Comments

@vicuna
Copy link

vicuna commented Feb 24, 2017

Original bug ID: 7493
Reporter: @damiendoligez
Status: confirmed (set by @damiendoligez on 2017-02-24T14:17:53Z)
Resolution: open
Priority: normal
Severity: feature
Version: 4.05.0 +dev/beta1/beta2/beta3/rc1
Category: compiler driver
Tags: junior_job

Bug description

Following the discussion in #217, the core team agreed that we would like a command-line option to make the compiler raise an error when compiling a .ml file if the corresponding .mli is missing.

@Octachron
Copy link
Member

A warning would probably be a better option than a compiler flag in this case.

@Anukriti12
Copy link
Contributor

Hi! I'm an Outreachy applicant. I looked up the source code and found parse_intf function of compile_common.ml is responsible for compilation of .mli interface file. I would like to work on this issue. As @Octachron suggested it's better to put a warning then a compiler flag I can put a wrapper which will check mli file path before actually compiling it.

@github-actions
Copy link

This issue has been open one year with no activity. Consequently, it is being marked with the "stale" label. What this means is that the issue will be automatically closed in 30 days unless more comments are added or the "stale" label is removed. Comments that provide new information on the issue are especially welcome: is it still reproducible? did it appear in other contexts? how critical is it? etc.

@github-actions github-actions bot added the Stale label Mar 31, 2021
@gasche
Copy link
Member

gasche commented Mar 31, 2021

The PR #9407 is in almost-mergeable state; I think we should make a decision there, either finish and merge it, or decide that we don't really want the feature and close the PR and the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants