Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manual: docitem macros for linking modules #9988

Merged
merged 2 commits into from Oct 28, 2020

Conversation

Octachron
Copy link
Member

Currently adding a new module to the manual documentation requires to update between two and three locations.

This PR build upon #9987 to eliminate one of those locations by defining unified macros for linking module from the html or latex side.

Those new macros are also useful when using alternative documentation generators that have different naming conventions for documentation files.

Along the way, I have updated the standard library module documentation test. It should now be able to detect incomplete updates of the documentation.

@gasche
Copy link
Member

gasche commented Oct 24, 2020

This could be rebased now that #9987 is merged.


\section{s:Module \texttt{UnixLabels}: labelized version of the interface}
\section{Module \texttt{UnixLabels}: labelized version of the interface}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the s: looks like a search-and-replace bug here, right? But how come we are not using the new \section{label}{title} macro?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't remember how I inserted this s: here.

Part of the issue is that this section heading is the only one in the manual that is inside an ocamldocinput section, which reinstall the normal section macro.

I have pushed a change to get out earlier of the ocamldocinput mode and avoid this corner case.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the new patch, the label is Unixlabels when I would maybe have expected s:Unixlabels, but I trust you to have done the right thing.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have merely kept the previous label since the label is unused, not in conflict with other labels, and only exists in the pure latex version of the manual.

Copy link
Member

@gasche gasche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a nice simplification/improvement to me. I have not tested the build, but I trust @Octachron to do it.

@Octachron Octachron merged commit 86528b0 into ocaml:trunk Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants