Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make old dune versions unavailable on win32 #25483

Open
raphael-proust opened this issue Mar 13, 2024 · 1 comment · Fixed by #25484
Open

make old dune versions unavailable on win32 #25483

raphael-proust opened this issue Mar 13, 2024 · 1 comment · Fixed by #25484

Comments

@raphael-proust
Copy link
Collaborator

raphael-proust commented Mar 13, 2024 •
edited

Note for opam-repository maintainers: this release fixes a critical issue for dune on Windows (support of unicode characters in PATH, e.g. usernames with accents) and i would suggest all the older versions of dune to be restricted to available: os != "win32" in a separate PR, independently of this one (this one should be merged first though).

Originally posted by @kit-ty-kate in #25474 (comment)
raphael-proust added a commit to raphael-proust/opam-repository that referenced this issue Mar 13, 2024
@raphael-proust
Mark old dune releases as not compatible with windows
ecc8b66 
fixes ocaml#25483
@raphael-proust raphael-proust mentioned this issue Mar 13, 2024
Merged
@kit-ty-kate kit-ty-kate reopened this Apr 2, 2024
@kit-ty-kate
Copy link
Member

Reverted in #25609

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Mark old dune releases as not compatible with windows raphael-proust/opam-repository
2 participants
@raphael-proust @kit-ty-kate