Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] devkit (1.20240429) #25760

Merged
merged 3 commits into from May 13, 2024
Merged

Conversation

Khady
Copy link
Contributor

@Khady Khady commented Apr 29, 2024

Development kit - general purpose library

CHANGES:
  • add opentelemetry support
  • remove depencency on ocamlnet

@mseri
Copy link
Member

mseri commented Apr 30, 2024

All tests are failing with linking errors

@raphael-proust
Copy link
Collaborator

The tests with OCaml5+ are indeed failing. The test executable doesn't link:

- File "dune", line 69, characters 8-12:
- 69 |   (name test)
-              ^^^^
- (cd _build/default && /home/opam/.opam/5.0/bin/ocamlopt.opt -w -40 -g -o test.exe /home/opam/.opam/5.0/lib/ocaml/unix/unix.cmxa /home/opam/.opam/5.0/lib/ocaml/threads/threads.cmxa /home/opam/.opam/5.0/lib/curl/curl.cmxa -I /home/opam/.opam/5.0/lib/curl /home/opam/.opam/5.0/lib/lwt/lwt.cmxa /home/opam/.opam/5.0/lib/ocplib-endian/ocplib_endian.cmxa /home/opam/.opam/5.0/lib/ocplib-endian/bigstring/ocplib_endian_bigstring.cmxa /home/opam/.opam/5.0/lib/lwt/unix/lwt_unix.cmxa -I /home/opam/.opam/5.0/lib/lwt/unix /home/opam/.opam/5.0/lib/curl/curl_lwt.cmx -I /home/opam/.opam/5.0/lib/curl /home/opam/.opam/5.0/lib/extlib/extlib.cmxa /home/opam/.opam/5.0/lib/extunix/ExtUnix.cmxa -I /home/opam/.opam/5.0/lib/extunix /home/opam/.opam/5.0/lib/libevent/liboevent.cmxa -I /home/opam/.opam/5.0/lib/libevent /home/opam/.opam/5.0/lib/pcre/pcre.cmxa -I /home/opam/.opam/5.0/lib/pcre /home/opam/.opam/5.0/lib/ocaml/str/str.cmxa ocamlnet_lite/ocamlnet_lite.cmxa /home/opam/.opam/5.0/lib/stdlib-shims/stdlib_shims.cmxa /home/opam/.opam/5.0/lib/trace/core/trace_core.cmxa /home/opam/.opam/5.0/lib/yojson/yojson.cmxa /home/opam/.opam/5.0/lib/zip/zip.cmxa -I /home/opam/.opam/5.0/lib/zip devkit_core.cmxa devkit.cmxa /home/opam/.opam/5.0/lib/ounit2/advanced/oUnitAdvanced.cmxa /home/opam/.opam/5.0/lib/ounit2/oUnit.cmxa .test.eobjs/native/dune__exe.cmx .test.eobjs/native/dune__exe__Test_httpev.cmx .test.eobjs/native/dune__exe__Test.cmx)
- /usr/bin/ld: /home/opam/.opam/5.0/lib/libevent/libmloevent.a(event_stubs.o): in function `event_cb':
- event_stubs.c:(.text+0xd1): undefined reference to `callback3'
- /usr/bin/ld: /home/opam/.opam/5.0/lib/libevent/libmloevent.a(event_stubs.o): in function `oc_event_base_init':
- event_stubs.c:(.text+0x9b0): undefined reference to `invalid_argument'
- collect2: error: ld returned 1 exit status
- File "caml_startup", line 1:
- Error: Error during linking (exit code 1)
[ERROR] The compilation of devkit.1.20240429 failed at "dune build -p devkit -j 255 @install @runtest".

Khady and others added 2 commits May 4, 2024 07:22
CHANGES:

- add opentelemetry support
- remove depencency on ocamlnet
@Khady Khady force-pushed the release-devkit-1.20240429 branch from 3ef8aaf to 0daa03e Compare May 4, 2024 07:22
@Khady
Copy link
Contributor Author

Khady commented May 4, 2024

The error was actually because of libevent.0.8.1. I've rebased the branch, the CI is now installing libevent.0.9.0 which was just merged, and the tests now are passing.

@mseri
Copy link
Member

mseri commented May 13, 2024

The remaining failure seems to be a problem in libevent.0.9.0 with macos arm:

#=== ERROR while compiling libevent.0.9.0 =====================================#
# context              2.2.0~beta1 | macos/arm64 | ocaml-base-compiler.4.14.2 | file:///Users/mac1000/opam-repository
# path                 ~/.opam/4.14.2/.opam-switch/build/libevent.0.9.0
# command              ~/.opam/opam-init/hooks/sandbox.sh build make depend
# exit-code            2
# env-file             ~/.opam/log/libevent-39041-0cb22f.env
# output-file          ~/.opam/log/libevent-39041-0cb22f.out
### output ###
# Makefile:99: depend: No such file or directory
# gcc -I /Users/mac1000/.opam/4.14.2/lib/ocaml -MM *.c > depend
# event_stubs.c:13:10: fatal error: 'event.h' file not found
# #include <event.h>
#          ^~~~~~~~~
# 1 error generated.
# make: *** [depend] Error 1

@mseri mseri merged commit 258d5ba into ocaml:master May 13, 2024
1 of 2 checks passed
@Khady Khady deleted the release-devkit-1.20240429 branch May 13, 2024 16:19
Khady added a commit to ahrefs/devkit that referenced this pull request May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants