Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] paf (2 packages) (0.6.0) #25808

Merged
merged 3 commits into from May 13, 2024
Merged

Conversation

dinosaure
Copy link
Contributor

dinosaure and others added 2 commits May 7, 2024 19:37
CHANGES:

- Fix typographie on errors (@hannesm, dinosaure/paf-le-chien#91)
- Introduce and use the new `shutdown` function (@hannesm, @dinosaure, dinosaure/paf-le-chien#92)
- Update to ocamlformat.0.26.1 (@dinosaure, dinosaure/paf-le-chien#94)
=== ERROR while compiling git-mirage.3.13.0 ==================================#
 context              2.2.0~beta3~dev | linux/x86_64 | ocaml-base-compiler.4.14.2 | file:///home/opam/opam-repository
 path                 ~/.opam/4.14/.opam-switch/build/git-mirage.3.13.0
 command              ~/.opam/opam-init/hooks/sandbox.sh build dune build -p git-mirage -j 31
 exit-code            1
 env-file             ~/.opam/log/git-mirage-7-ed8b26.env
 output-file          ~/.opam/log/git-mirage-7-ed8b26.out
== output ###
 (cd _build/default && /home/opam/.opam/4.14/bin/ocamlopt.opt -w -40 -g -I src/git-mirage/.git_mirage_http.objs/byte -I src/git-mirage/.git_mirage_http.objs/native -I /home/opam/.opam/4.14/lib/base64 -I /home/opam/.opam/4.14/lib/ca-certs-nss -I /home/opam/.opam/4.14/lib/cstruct -I /home/opam/.opam/4.14/lib/domain-name -I /home/opam/.opam/4.14/lib/fmt -I /home/opam/.opam/4.14/lib/git-paf -I /home/opam/.opam/4.14/lib/git/nss/git -I /home/opam/.opam/4.14/lib/hex -I /home/opam/.opam/4.14/lib/lwt -I /home/opam/.opam/4.14/lib/mimic -I /home/opam/.opam/4.14/lib/mimic-happy-eyeballs -I /home/opam/.opam/4.14/lib/mirage-clock -I /home/opam/.opam/4.14/lib/mirage-crypto -I /home/opam/.opam/4.14/lib/mirage-flow -I /home/opam/.opam/4.14/lib/mirage-time -I /home/opam/.opam/4.14/lib/ptime -I /home/opam/.opam/4.14/lib/result -I /home/opam/.opam/4.14/lib/tcpip -I /home/opam/.opam/4.14/lib/tls -I /home/opam/.opam/4.14/lib/tls-mirage -I /home/opam/.opam/4.14/lib/uri -I /home/opam/.opam/4.14/lib/x509 -intf-suffix .ml -no-alias-deps -o src/git-mirage/.git_mirage_http.objs/native/git_mirage_http.cmx -c -impl src/git-mirage/git_mirage_http.ml)
 File "src/git-mirage/git_mirage_http.ml", line 198, characters 73-77:
 198 |   let http_endpoint, http_protocol = Mimic.register ~name:"http" (module HTTP)
                                                                                ^^^^
 Error: Signature mismatch:
        ...
        The value `shutdown' is required but not provided
        File "src/mirage_flow.mli", line 98, characters 2-71:
          Expected declaration
 (cd _build/default && /home/opam/.opam/4.14/bin/ocamlc.opt -w -40 -g -bin-annot -I src/git-mirage/.git_mirage_http.objs/byte -I /home/opam/.opam/4.14/lib/base64 -I /home/opam/.opam/4.14/lib/ca-certs-nss -I /home/opam/.opam/4.14/lib/cstruct -I /home/opam/.opam/4.14/lib/domain-name -I /home/opam/.opam/4.14/lib/fmt -I /home/opam/.opam/4.14/lib/git-paf -I /home/opam/.opam/4.14/lib/git/nss/git -I /home/opam/.opam/4.14/lib/hex -I /home/opam/.opam/4.14/lib/lwt -I /home/opam/.opam/4.14/lib/mimic -I /home/opam/.opam/4.14/lib/mimic-happy-eyeballs -I /home/opam/.opam/4.14/lib/mirage-clock -I /home/opam/.opam/4.14/lib/mirage-crypto -I /home/opam/.opam/4.14/lib/mirage-flow -I /home/opam/.opam/4.14/lib/mirage-time -I /home/opam/.opam/4.14/lib/ptime -I /home/opam/.opam/4.14/lib/result -I /home/opam/.opam/4.14/lib/tcpip -I /home/opam/.opam/4.14/lib/tls -I /home/opam/.opam/4.14/lib/tls-mirage -I /home/opam/.opam/4.14/lib/uri -I /home/opam/.opam/4.14/lib/x509 -intf-suffix .ml -no-alias-deps -o src/git-mirage/.git_mirage_http.objs/byte/git_mirage_http.cmo -c -impl src/git-mirage/git_mirage_http.ml)
 File "src/git-mirage/git_mirage_http.ml", line 198, characters 73-77:
 198 |   let http_endpoint, http_protocol = Mimic.register ~name:"http" (module HTTP)
                                                                                ^^^^
 Error: Signature mismatch:
        ...
        The value `shutdown' is required but not provided
        File "src/mirage_flow.mli", line 98, characters 2-71:
          Expected declaration
@hannesm
Copy link
Member

hannesm commented May 8, 2024

Thanks for this release. There are some reverse dependencies that fail -- git-mirage 3.13.0 3.14.0 3.15.0 due to signature mismatches:

#=== ERROR while compiling git-mirage.3.13.0 ==================================#
# context              2.2.0~beta3~dev | linux/x86_64 | ocaml-base-compiler.4.14.2 | file:///home/opam/opam-repository
# path                 ~/.opam/4.14/.opam-switch/build/git-mirage.3.13.0
# command              ~/.opam/opam-init/hooks/sandbox.sh build dune build -p git-mirage -j 31
# exit-code            1
# env-file             ~/.opam/log/git-mirage-7-ed8b26.env
# output-file          ~/.opam/log/git-mirage-7-ed8b26.out
### output ###
# (cd _build/default && /home/opam/.opam/4.14/bin/ocamlopt.opt -w -40 -g -I src/git-mirage/.git_mirage_http.objs/byte -I src/git-mirage/.git_mirage_http.objs/native -I /home/opam/.opam/4.14/lib/base64 -I /home/opam/.opam/4.14/lib/ca-certs-nss -I /home/opam/.opam/4.14/lib/cstruct -I /home/opam/.opam/4.14/lib/domain-name -I /home/opam/.opam/4.14/lib/fmt -I /home/opam/.opam/4.14/lib/git-paf -I /home/opam/.opam/4.14/lib/git/nss/git -I /home/opam/.opam/4.14/lib/hex -I /home/opam/.opam/4.14/lib/lwt -I /home/opam/.opam/4.14/lib/mimic -I /home/opam/.opam/4.14/lib/mimic-happy-eyeballs -I /home/opam/.opam/4.14/lib/mirage-clock -I /home/opam/.opam/4.14/lib/mirage-crypto -I /home/opam/.opam/4.14/lib/mirage-flow -I /home/opam/.opam/4.14/lib/mirage-time -I /home/opam/.opam/4.14/lib/ptime -I /home/opam/.opam/4.14/lib/result -I /home/opam/.opam/4.14/lib/tcpip -I /home/opam/.opam/4.14/lib/tls -I /home/opam/.opam/4.14/lib/tls-mirage -I /home/opam/.opam/4.14/lib/uri -I /home/opam/.opam/4.14/lib/x509 -intf-suffix .ml -no-alias-deps -o src/git-mirage/.git_mirage_http.objs/native/git_mirage_http.cmx -c -impl src/git-mirage/git_mirage_http.ml)
# File "src/git-mirage/git_mirage_http.ml", line 198, characters 73-77:
# 198 |   let http_endpoint, http_protocol = Mimic.register ~name:"http" (module HTTP)
#                                                                                ^^^^
# Error: Signature mismatch:
#        ...
#        The value `shutdown' is required but not provided
#        File "src/mirage_flow.mli", line 98, characters 2-71:
#          Expected declaration
# (cd _build/default && /home/opam/.opam/4.14/bin/ocamlc.opt -w -40 -g -bin-annot -I src/git-mirage/.git_mirage_http.objs/byte -I /home/opam/.opam/4.14/lib/base64 -I /home/opam/.opam/4.14/lib/ca-certs-nss -I /home/opam/.opam/4.14/lib/cstruct -I /home/opam/.opam/4.14/lib/domain-name -I /home/opam/.opam/4.14/lib/fmt -I /home/opam/.opam/4.14/lib/git-paf -I /home/opam/.opam/4.14/lib/git/nss/git -I /home/opam/.opam/4.14/lib/hex -I /home/opam/.opam/4.14/lib/lwt -I /home/opam/.opam/4.14/lib/mimic -I /home/opam/.opam/4.14/lib/mimic-happy-eyeballs -I /home/opam/.opam/4.14/lib/mirage-clock -I /home/opam/.opam/4.14/lib/mirage-crypto -I /home/opam/.opam/4.14/lib/mirage-flow -I /home/opam/.opam/4.14/lib/mirage-time -I /home/opam/.opam/4.14/lib/ptime -I /home/opam/.opam/4.14/lib/result -I /home/opam/.opam/4.14/lib/tcpip -I /home/opam/.opam/4.14/lib/tls -I /home/opam/.opam/4.14/lib/tls-mirage -I /home/opam/.opam/4.14/lib/uri -I /home/opam/.opam/4.14/lib/x509 -intf-suffix .ml -no-alias-deps -o src/git-mirage/.git_mirage_http.objs/byte/git_mirage_http.cmo -c -impl src/git-mirage/git_mirage_http.ml)
# File "src/git-mirage/git_mirage_http.ml", line 198, characters 73-77:
# 198 |   let http_endpoint, http_protocol = Mimic.register ~name:"http" (module HTTP)
#                                                                                ^^^^
# Error: Signature mismatch:
#        ...
#        The value `shutdown' is required but not provided
#        File "src/mirage_flow.mli", line 98, characters 2-71:
#          Expected declaration

I pushed a commit that restricts these git-mirage versions to mirage-flow < 4.

@dinosaure
Copy link
Contributor Author

Not sure how to interpret the timeout error for 4.{08,09,10}. But as far as I can see, it's ready to merge.

@mseri
Copy link
Member

mseri commented May 13, 2024

Those are opam 2.0 tests, timeouts are kind of known to appear for some packages

@mseri mseri merged commit 0d2fd1b into ocaml:master May 13, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants