Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider Changing PR Preview Configuration #183

Closed
nerddtvg opened this issue Jul 27, 2023 · 2 comments · Fixed by #189
Closed

Consider Changing PR Preview Configuration #183

nerddtvg opened this issue Jul 27, 2023 · 2 comments · Fixed by #189
Assignees

Comments

@nerddtvg
Copy link
Contributor

Netlify has served us well for deployment previews but when builds fail, it's hard to re-run them due to the lack of licensing.

GitHub Pages is coming out with a PR Preview feature but it is currently in Alpha. Can we volunteer for testing access if we report issues?

Can we consider using the deploy-pr-preview Action published here instead?

https://github.com/marketplace/actions/deploy-pr-preview

This Action would deploy the preview as a subfolder under our existing site, one that can be removed after PRs are merged as well. Seems easy to use and decently supported.

@nerddtvg nerddtvg self-assigned this Jul 27, 2023
@nerddtvg
Copy link
Contributor Author

Issues possibly related to the failing builds:

npm/cli#4652
nodejs/node#47130 (comment) (Node v19 but we use v18)
node-fetch/node-fetch#1735

@nerddtvg
Copy link
Contributor Author

Turns out the deploy-pr-preview action is for classic GitHub Pages which deploys off a branch instead of as immutable copies. We need to use something else. A static site running on S3 or Azure Storage would be pretty easy to setup per-PR and destroy when the PR is closed.

Example:
https://github.com/marketplace/actions/s3-website-pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant