Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade to use aws api v3 (#1215) #1240

Merged
merged 7 commits into from
Jan 10, 2024
Merged

feat: upgrade to use aws api v3 (#1215) #1240

merged 7 commits into from
Jan 10, 2024

Conversation

mdonnalley
Copy link
Contributor

Merges #1215

Signed-off-by: Amndeep Singh Mann <amann@mitre.org>
@Amndeep7
Copy link
Contributor

Amndeep7 commented Jan 9, 2024

@mdonnalley seems like your CI might need to pass AWS_REGION as well in https://github.com/oclif/oclif/blob/main/.github/workflows/test.yml for each of the platforms

@mdonnalley
Copy link
Contributor Author

QA: Tested that this version is able to successfully publish sf: https://github.com/salesforcecli/cli/actions/runs/7466357735

@mdonnalley mdonnalley merged commit e781906 into main Jan 10, 2024
22 checks passed
@mdonnalley mdonnalley deleted the mdonnalley/1215 branch January 10, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants