feat: no yeoman

[mdonnalley]

• Removes dependencies on yeoman-generator and yeoman-environment (fixes Oclif using deprecated transient dependencies and showing npm WARN #1294)
• Exposes all prompts on oclif generate as flags so that users can programmatically answer prompts (similar to npm init --name my-pkg
• Adds a --yes flag on oclif generate that will automatically accept defaults for all prompts (similar to npm init --yes)
• Adds yarn-specific items to generated .gitignore (fixes Default .gitignore content generated using yarn 2+ is missing recommended lines by yarn #1152)
• Adds --commands-dir flag to oclif generate command to allow users to select an alternative destination for the generated command (defaults to src/commands)
• Standardizes help content across all commands (capitalize first letter, end with period, separate summary and description)

@W-15044742@
@W-15161957@

[jpshackelford]

Very glad to see this work. I am making a choice between oclif and commander today and seeing these warnings had me worried about whether oclif was actively maintained. I certainly would not want users of my CLI to be greeted with this. Thanks for the PR!

$ npm install -g oclif 
npm WARN deprecated debuglog@1.0.1: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.
npm WARN deprecated readdir-scoped-modules@1.1.0: This functionality has been moved to @npmcli/fs
npm WARN deprecated @npmcli/move-file@1.1.2: This functionality has been moved to @npmcli/fs
npm WARN deprecated @npmcli/move-file@2.0.1: This functionality has been moved to @npmcli/fs
npm WARN deprecated @npmcli/move-file@2.0.1: This functionality has been moved to @npmcli/fs

added 1052 packages in 13s

[moltar]

Can't wait for this to merge. Such an eye sore in the terminal to see all those warnings.

[mdonnalley]

Thanks @moltar - hoping to get this out tomorrow or early next week. Just waiting on a coworker to review and test.

[cristiand391]

I couldn't find where yeoman was using this env, seems it did a while ago but now it does an unauthenticated request, and relies on the user having an email setup in git:

https://github.com/yeoman/generator/blob/71dcba00427d7e382c1c32af68dbb7666ee0269f/src/actions/user.ts#L51-L52

https://github.com/sindresorhus/github-username/blob/c716cf8e920430dc319c44ab7586ab2e72b91467/index.js#L18

Either way works so it should be fine, the precedence seems for getting the username looks like:

1. GH API (if token)
2. git username (if available)
3. pjson.author in template

I'll check on QA 👍🏼

[cristiand391]

lgtm. I'll QA mainly on windows to ensure the generator works there.

[cristiand391]

QA notes:

✅ can generate a CLI/command/hook successfully on windows, all paths are correct and can run command/hooks/tests
✅ values provided via flags are respected and only get prompted for the missing ones
✅ both npm/yarn work for generated plugins
NOTE: now that the default PM is npm the first npm install takes a bit longer because there's no package-lock.json in the templates repo, so users might get something different from what gets tested in the templates repo.

✅ all defaults with --all
❌ can't make it pick up my username from local git

latest oclif:

this branch:

➜  oclif git:(mdonnalley/no-yeoman) ✗ git config --get user.name
Cristian Dominguez

so the homepage/bug fields are wrong in the pjson:

...
  "homepage": "https://github.com/oclif/qa2",
  "bugs": "https://github.com/oclif/qa2/issues",
...
`

[cristiand391]

qa update:

✅ get username from git:

➜  oclif git:(mdonnalley/no-yeoman) ./bin/run.js generate asdf
Generating asdf in /Users/cdominguez/code/gh/oclif/oclif/asdf
? Select a module type ESM
? NPM package name asdf
? Command bin name the CLI will export asdf
? Description oclif example Hello World CLI (ESM)
? Author Cristian Dominguez
? License MIT
? Who is the GitHub owner of repository (https://github.com/OWNER/repo) oclif
? What is the GitHub name of repository (https://github.com/owner/REPO) asdf
? Select a package manager (Use arrow keys)
❯ npm
  yarn

NOTE
yeoman was able to get the GH username from the email found in git config using the github-username pkg, so the default value for owner would be that, but now you need to manually type it for the URLs to be right.

➜  oclif git:(mdonnalley/no-yeoman) ✗ oclif generate qa2
Time to build an oclif CLI! Version: 4.5.7
? Select a module type CommonJS
Cloning into '/Users/cdominguez/code/gh/oclif/oclif/qa2'...
? npm package name qa2
? command bin name the CLI will export qa2
? description oclif example Hello World CLI
? author Cristian Dominguez @cristiand391
? license MIT
? Who is the GitHub owner of repository (https://github.com/OWNER/repo) cristiand391
? What is the GitHub name of repository (https://github.com/owner/REPO) qa2
? Select a package manager (Use arrow keys)
  npm
❯ yarn