Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimum required Node.js version #7

Closed
jaydenseric opened this issue May 23, 2022 · 4 comments
Closed

Minimum required Node.js version #7

jaydenseric opened this issue May 23, 2022 · 4 comments

Comments

@jaydenseric
Copy link

In v2 the minimum required Node.js version is v14.18.0:

"engines": {
"node": ">= 14.18"
},

Is that necessary, or can it be lowered to v14.17.0? The reason I ask is because I’ve been rolling that out as the minimum for my packages and in particular would rather not increase this for the upcoming graphql-upload major version:

https://github.com/jaydenseric/graphql-upload/blob/6da4fb2cdf8e4610a251babb5632bf9b97ce9f71/package.json#L47-L49

I think a lot of packages in the ecosystem will settle on Node.js v14.17.0 as the minimum to support, including it looks like node-fetch v4: node-fetch/node-fetch#1452 .

@octet-stream
Copy link
Owner

I think I can lower it. The tests seem to pass on 14.17.
The problem was just that I can't run pnpm under Node 14.17, but it seem to be totally unnecessary, because I don't use it outside of my machine except for CI, but it runs on 14.x, 16.x and 18.x. Which means GitHub will use latest version of each.

@octet-stream
Copy link
Owner

Done. https://github.com/octet-stream/form-data-encoder/releases/tag/v2.0.1

@jaydenseric
Copy link
Author

Thanks! I'll update now :)

@octet-stream
Copy link
Owner

Ah, I just remembered: I was trying to add some test for Node.js Blob in my formdata-node package, but it was added in 14.18. So I also considered that and set minimal version to 14.18 for this package too. But these test aren't essential, so I will just remove them and adjust minimal version in formdata-node too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants