Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up linting for GitHub Actions workflows #1241

Open
Belco90 opened this issue Oct 18, 2022 · 3 comments
Open

Set up linting for GitHub Actions workflows #1241

Belco90 opened this issue Oct 18, 2022 · 3 comments
Assignees
Labels
chore Changes that affect the build system, CI config or other changes that don't modify src/test f

Comments

@Belco90
Copy link
Member

Belco90 commented Oct 18, 2022

What internal change would you like to have?

Set up actionlint in the repo.

What problem will this change solve?

Anticipate mistakes when writing GitHub Actions workflows.

Do you want to help make the feature?

Yes

Is there anything else we need to know?

No response

@Belco90 Belco90 self-assigned this Oct 18, 2022
@Belco90 Belco90 added the chore Changes that affect the build system, CI config or other changes that don't modify src/test f label Oct 18, 2022
@HonkingGoose
Copy link
Collaborator

Maybe this VSCode extension can help with writing/checking GitHub Action files:

https://marketplace.visualstudio.com/items?itemName=github.vscode-github-actions

@Belco90
Copy link
Member Author

Belco90 commented May 15, 2023

That will definitely help (I use a similar one for my IDE), but would be better to lint it in CI to make sure it's fine no matter the developer local config.

@HonkingGoose
Copy link
Collaborator

Linting in CI is best! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Changes that affect the build system, CI config or other changes that don't modify src/test f
Projects
Status: Todo
Development

No branches or pull requests

2 participants