Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style link + icon in changelog item differently from main link #151

Open
HonkingGoose opened this issue Jun 11, 2021 · 0 comments
Open

Style link + icon in changelog item differently from main link #151

HonkingGoose opened this issue Jun 11, 2021 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@HonkingGoose
Copy link
Collaborator

What feature would you like to have?

Seeing as we won't implement #149 until after we finished the revamp, I need a way to de-emphasize the links to the GitHub issue number and the commit hash in the changelog item list.

I think we currently have only one link style?

https://github.com/Belco90/octoclairvoyant/blob/250d3d78a75dfbbc5193127726b8e385c40fd83e/src/components/Link.tsx#L1-L7

I'd like to have a way to change the color for link items in the changelog view.
I don't know if this is already possible, I haven't found the code that generates the line items.

I'd also like to be able to change the icon color as well (some changelog links have a "external link" icon).

Maybe we can create a new component, or find some other "clean way" to do this change? I worry that we're adding overrides to things in too many places, and that will make it harder to maintain the site later on.

What problem will be solved by having the feature?

Makes the changelog content easier to read, as there will be less color.

We can add a dash of color once the user hovers/focus/clicks on the issue link/commit hash. 😉

Do you want to help making the feature?

I'm willing to change the colors myself, but I don't know where to find the code that adds the issue link/commit hash, so I cannot override those with a custom color.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

2 participants