Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT]: Authenticate as app with custom JWT token #484

Open
1 task done
revblock opened this issue Nov 21, 2023 · 2 comments
Open
1 task done

[FEAT]: Authenticate as app with custom JWT token #484

revblock opened this issue Nov 21, 2023 · 2 comments
Labels
Type: Feature New feature or request Type: Support Any questions, information, or general needs around the SDK or GitHub APIs

Comments

@revblock
Copy link

Describe the need

I want to be able to create an App instance using a custom JWT token rather than having to pass in a private key.

My use case is that my private key is stored in a KMS so I don't have direct access to it. This means that I need to create the JWT and sign it there, I can then use it with octokit.

I think I'll be able to get around this manually but it would be nice if octokit handled this scenario.

Thanks

SDK Version

No response

API Version

No response

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@revblock revblock added Status: Triage This is being looked at and prioritized Type: Feature New feature or request labels Nov 21, 2023
Copy link

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@gr2m
Copy link
Contributor

gr2m commented Nov 21, 2023

JWTs are very short lived, app.js relies on being able to create one as needed for it to function.

What do you need to use the JWT for? You can just use https://github.com/octokit/core.js or https://github.com/octokit/request.js and set the JWT as auth: JWT or headers: {authorization: bearer ${JWT } respectively

@kfcampbell kfcampbell added Type: Support Any questions, information, or general needs around the SDK or GitHub APIs and removed Status: Triage This is being looked at and prioritized labels Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New feature or request Type: Support Any questions, information, or general needs around the SDK or GitHub APIs
Projects
Status: 🛑 Blocked/Awaiting Response
Development

No branches or pull requests

3 participants