Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: octokit.request("PATCH /app/hook/config", { url }) throws error installationId option is required for installation authentication #584

Open
1 task done
gr2m opened this issue Mar 5, 2024 · 1 comment
Labels
Type: Bug Something isn't working as documented, or is being fixed

Comments

@gr2m
Copy link
Contributor

gr2m commented Mar 5, 2024

What happened?

The reason for this is that url is a special argument that octokit is using internally. I think a long time ago I asked the API to rename the parameter because of that conflict, also webhook_url would be more clear anyway.

Here is a workaround for anyone who runs into it

await octokit.request("PATCH /app/hook/config", {
  data: { url },
});

Versions

any

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@gr2m gr2m added Status: Triage This is being looked at and prioritized Type: Bug Something isn't working as documented, or is being fixed labels Mar 5, 2024
Copy link
Contributor

github-actions bot commented Mar 5, 2024

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@kfcampbell kfcampbell removed the Status: Triage This is being looked at and prioritized label Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working as documented, or is being fixed
Projects
Status: 🔥 Backlog
Development

No branches or pull requests

2 participants