Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit skipped tests #602

Open
wolfy1339 opened this issue Apr 30, 2024 · 1 comment
Open

Revisit skipped tests #602

wolfy1339 opened this issue Apr 30, 2024 · 1 comment
Labels
Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR

Comments

@wolfy1339
Copy link
Member

wolfy1339 commented Apr 30, 2024 •
edited

I still see the tests that use the jest.advanceTimersByTimeAsync() API fail like once out of 7 runs. Honestly at this point I'd tear out jest, and for the time being live with re-running CI when the tests fail

Originally posted by @gr2m in #580 (comment)
@wolfy1339 wolfy1339 added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Apr 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
🧰 Octokit Active
Status: 🔥 Backlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wolfy1339