Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINT]: Link to "Code of Conduct" is wrong in issue templates #399

Open
1 task done
NatoBoram opened this issue Mar 28, 2024 · 4 comments
Open
1 task done

[MAINT]: Link to "Code of Conduct" is wrong in issue templates #399

NatoBoram opened this issue Mar 28, 2024 · 4 comments
Labels
Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR

Comments

@NatoBoram
Copy link

Describe the need

This code here:

description: By submitting this issue, you agree to follow our [Code of Conduct](CODE_OF_CONDUCT.md)

does this:

image

but it links to https://github.com/octokit/auth-token.js/issues/CODE_OF_CONDUCT.md instead of https://github.com/octokit/auth-token.js#coc-ov-file

SDK Version

No response

API Version

No response

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@NatoBoram NatoBoram added Status: Triage This is being looked at and prioritized Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR labels Mar 28, 2024
Copy link

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@gr2m
Copy link
Contributor

gr2m commented Mar 28, 2024

@octokit/js I think a CODE_OF_CONDUCT file does not need to be present in all repositories, we already have it in https://github.com/octokit/.github/blob/main/CODE_OF_CONDUCT.md which should be recognized by all repositories. Maybe we just link to that and remove the CODE_OF_CONDUCT.md files from other repositories?

@NatoBoram
Copy link
Author

NatoBoram commented Mar 29, 2024

Having it in the repo shows it up in the sidebar and over the README.md, not sure how important this is for you

Sidebar Homepage
image image

@gr2m
Copy link
Contributor

gr2m commented Mar 29, 2024

Having it in the repo shows it up in the sidebar and over the README.md, not sure how important this is for you

I think the same should be the case if the repo has no CoC file, but the owner's .github repo has one, but we would need to verify it first

@kfcampbell kfcampbell removed the Status: Triage This is being looked at and prioritized label Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
Status: 🔥 Backlog
Development

No branches or pull requests

3 participants