Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement types for authentication strategies #323

Open
gr2m opened this issue Apr 18, 2021 · 4 comments
Open

Implement types for authentication strategies #323

gr2m opened this issue Apr 18, 2021 · 4 comments
Labels
project Status: Blocked Some technical or requirement is blocking the issue Type: Feature New feature or request typescript Relevant to TypeScript users only
Projects

Comments

@gr2m
Copy link
Contributor

gr2m commented Apr 18, 2021

Blocked by octokit/octokit.js#2127

What’s missing?

THere is currently no way to define types for authentication strategy options:

new Octokit({
  authStrategy: createMyAuth,
  auth: myAuthOptions
})

Why?

It would be great to get the same intellisense as for the other options

Alternatives you tried

@weswigham layed out how this is possible to do in octokit/rest.js#13 (comment)

We plan to implement endpoints the same way, so we can remove the endpoint types from @octokit/types, and instead move it to an optional library, or multiple libraries even, so that we can provide the correct types for each GitHub Enterprise Server version.

This is going to be a bigger project.

@chrissyjai

This comment has been minimized.

@gr2m gr2m added the Status: Blocked Some technical or requirement is blocking the issue label Jul 9, 2021
@ghost ghost moved this from Roadmap to Blocked in JS Jul 9, 2021
@MelnikovAG

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
project Status: Blocked Some technical or requirement is blocking the issue Type: Feature New feature or request typescript Relevant to TypeScript users only
Projects
No open projects
JS
  
Blocked
Development

No branches or pull requests

6 participants
@gr2m @MelnikovAG @chrissyjai and others