Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(types): convert type 'OctokitOptions' to interface #450

Merged
merged 1 commit into from Mar 3, 2022
Merged

feat(types): convert type 'OctokitOptions' to interface #450

merged 1 commit into from Mar 3, 2022

Conversation

oscard0m
Copy link
Member

@oscard0m oscard0m commented Mar 3, 2022

Fixes #449

@ghost ghost added this to Inbox in JS Mar 3, 2022
@oscard0m oscard0m requested a review from gr2m March 3, 2022 17:19
@oscard0m oscard0m added the Type: Feature New feature or request label Mar 3, 2022
@ghost ghost moved this from Inbox to Features in JS Mar 3, 2022
oscard0m
oscard0m commented Mar 3, 2022
View reviewed changes
src/types.ts Show resolved Hide resolved
@wolfy1339
Copy link
Member

Might as well go through the rest of the repos and change from type to interface.

@gr2m gr2m merged commit 0151ef0 into master Mar 3, 2022
JS automation moved this from Features to Done Mar 3, 2022
@gr2m gr2m deleted the convert-type-OctokitOptions-to-interface branch March 3, 2022 19:21
@oscard0m oscard0m mentioned this pull request Mar 10, 2022
Merged
@github-actions
Copy link
Contributor

🎉 This PR is included in version 3.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@NOUIY NOUIY mentioned this pull request Oct 1, 2022
Open
@adamlaska adamlaska mentioned this pull request Oct 3, 2022
Open
@NOUIY NOUIY mentioned this pull request Oct 13, 2022
Open
@NOUIY NOUIY mentioned this pull request Jun 14, 2023
Open
@NOUIY NOUIY mentioned this pull request Sep 23, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolfy1339 wolfy1339 wolfy1339 approved these changes

@gr2m gr2m gr2m approved these changes

@G-Rath G-Rath Awaiting requested review from G-Rath

Assignees
No one assigned
Labels
Type: Feature New feature or request
Projects
No open projects
JS
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert type OctokitOptions to interface OctokitOptions
3 participants
@oscard0m @wolfy1339 @gr2m