Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maintenance] automated release failed #451

Closed
gr2m opened this issue Mar 3, 2022 · 7 comments · Fixed by #454
Closed

[Maintenance] automated release failed #451

gr2m opened this issue Mar 3, 2022 · 7 comments · Fixed by #454
Assignees
Labels
Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects

Comments

@gr2m
Copy link
Contributor

gr2m commented Mar 3, 2022

See https://github.com/octokit/core.js/runs/5412497631?check_suite_focus=true. Any idea what might have happened?

@gr2m gr2m added the Type: Bug Something isn't working as documented label Mar 3, 2022
@ghost ghost added this to Bugs in JS Mar 3, 2022
@gr2m gr2m added Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR and removed Type: Bug Something isn't working as documented labels Mar 3, 2022
@ghost ghost moved this from Bugs to Maintenance in JS Mar 3, 2022
@KAMORU9

This comment was marked as spam.

@wolfy1339
Copy link
Member

This isn't the first time this has happened.

When trying it out locally, I found that using pika-pack works.

That's also how it is defined in their package.json

https://unpkg.com/browse/@pika/pack@0.5.0/package.json

@oscard0m
Copy link
Member

I will take a look into it next week.

@oscard0m
Copy link
Member

Seems like pika is kind of unmaintained:
FredKSchott/pika-pack#91 (comment)

Do you mind if I open a discussion under octokit.js on how how we should be building Octokit projects from now on?

If not, I guess we will need task for migrating (with Octoherd?) all the scripts to pika-pack

@gr2m
Copy link
Contributor Author

gr2m commented Mar 13, 2022

how how we should be building Octokit projects from now on

basically how https://github.com/octokit/octokit-next.js is built: everything is written as ES Module JavaScript, no more build step at all. d.ts files are written by hand.

@gr2m gr2m closed this as completed in #454 Mar 13, 2022
JS automation moved this from Maintenance to Done Mar 13, 2022
@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 3.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gr2m
Copy link
Contributor Author

gr2m commented Mar 13, 2022

👆🏼yay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
No open projects
JS
  
Done
Development

Successfully merging a pull request may close this issue.

6 participants
@gr2m @oscard0m @wolfy1339 @KAMORU9 and others