Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: stop testing against NodeJS v10, v12 #488

Merged
merged 6 commits into from Jul 7, 2022
Merged

Conversation

wolfy1339
Copy link
Member

BREAKING CHANGE: Drop support for NodeJS v10, v12

@wolfy1339 wolfy1339 added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Jul 7, 2022
@ghost ghost added this to Inbox in JS Jul 7, 2022
@ghost ghost moved this from Inbox to Maintenance in JS Jul 7, 2022
@wolfy1339
Copy link
Member Author

The tests are failing on node v18, not sure why

@oscard0m
Copy link
Member

oscard0m commented Jul 7, 2022

The tests are failing on node v18, not sure why

Interesting. Let's open an issue with the logs of the tests failing so we keep track on this?

@wolfy1339
Copy link
Member Author

I removed nove v18 for now until now and opened #489

@wolfy1339 wolfy1339 merged commit e54e6c3 into master Jul 7, 2022
JS automation moved this from Maintenance to Done Jul 7, 2022
@wolfy1339 wolfy1339 deleted the remove-eol-node-versions branch July 7, 2022 22:23
@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2022

🎉 This PR is included in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
No open projects
JS
  
Done
Development

Successfully merging this pull request may close these issues.

Remove Node version 10 from .github/workflows/test.yml
2 participants