feat: rewrite in ESModules

[wolfy1339]

No description provided.

[wolfy1339]

There's 3 commits that aren't totally related to this PR, that fix deprecation warnings with tap

• fix: replace deprecated t.is with t.equal 2ce8b05
• fix: replace t.isA with t.type c5bf865
• fix: replace t.deepEqual with t.same 9a5cbbf

Should I split them off?

---

Otherwise, the tests run, but they fail due to mismatches in expected output. I am unsure why that would happen with the switch to ESM.

[gr2m]

you had incorrect imports. If the file has

export default temporaryRepository;
export const regex

then you cannot access temporaryRepository.regex, you have to do

import temporaryRepository, { regex } from '...'

[gr2m]

Hm I cannot reproduce the failing test locally, can you?

Also npm run record is currently failing, I'm looking into that

[wolfy1339]

I cannot reproduce the failing test locally with NodeJS v16

[wolfy1339]

Also npm run record is currently failing, I'm looking into that

It's because in ESM you can't implicitly import the index.js located in a folder, you have to import it explicitly. Which I did account for. Must've missed these ones
I found another case of it in bin/remove-temporary-repositories.js

[gr2m]

depends on #411

[wolfy1339]

Alright, only 3 failing tests remain.

There's a problem with bin/record.js --update, it's removing data from fixtures.

[gr2m]

We are down the the normalize test failing because of how the entity IDs are calculated. I tried to figure out where the diff is coming from but I don't know. I think it might be that the keys in an object are sorted differently, because IDs from the recorded fixtures are mapped to the made-up IDs starting at 1000 instead. Maybe you have an idea what might be going on? It's odd because the record tests all pass, but when running the normalization test in isolation it finds a diff

[wolfy1339]

Pinging @octokit/js-community
Can of you look at this to help figure out why the IDs are differing between the CommonJS version and this PR?

[wolfy1339]

The problem seems to stem from using Promises.
Making the test use a for-of loop instead of Promise.all makes it pass. (also changing the Promise.all in lib/normalize/index.js)

[wolfy1339]

With this patch the test works normally.

diff --git a/lib/normalize/index.js b/lib/normalize/index.js
index 129e5f8..a7c879c 100644
--- a/lib/normalize/index.js
+++ b/lib/normalize/index.js
@@ -83,17 +83,15 @@ async function normalize(scenarioState, fixture) {
   const responses = Array.isArray(fixture.response)
     ? fixture.response
     : [fixture.response];
-  await Promise.all(
-    responses.map(async (response) => {
-      normalizeCommon(response);
-      const entityName = toEntityName(response, fixture);
-      if (entityName) {
-        await (
-          await import(`./${entityName}.js`)
-        ).default(scenarioState, response, fixture);
-      }
-    })
-  );
+  for (let response of responses) {
+    normalizeCommon(response);
+    const entityName = toEntityName(response, fixture);
+    if (entityName) {
+      await (
+        await import(`./${entityName}.js`)
+      ).default(scenarioState, response, fixture);
+    }
+  }
 
   // update content length
   if (/^application\/json/.test(fixture.headers["content-type"])) {
diff --git a/test/integration/normalize.test.js b/test/integration/normalize.test.js
index 9166649..accbe2f 100644
--- a/test/integration/normalize.test.js
+++ b/test/integration/normalize.test.js
@@ -19,9 +19,11 @@ glob
         commitSha: {},
         ids: {},
       };
-      const actual = await Promise.all(
-        raw.filter(isntIgnored).map(normalize.bind(null, scenarioState))
-      );
+      const actual = [];
+      for (let item of raw.filter(isntIgnored)) {
+        let result = await normalize.bind(null, scenarioState)(item);
+        actual.push(result);
+      }
       expect(actual).toEqual(expected);
     });
   });

All thanks to my friend @io4 who diagnosed this and found the issue

[gr2m]

sounds great 👍🏼 thanks @io4! Can you push the change?

[gr2m]

Great work 👏🏼

[github-actions]

🎉 This PR is included in version 22.0.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀