Expose type and error constructor for graphql response errors #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exposes types and the error constructor for the error being thrown when a GraphQL response contains errors. This allows consumers to easily distinguish between unrelated errors vs. graphql related errors, and allows for type-guarded access of the response data / response headers.
ghost
added this to Inbox
in 
gr2m
added
Type: Feature
|
can you check the remaining errors? Do the tests pass for you locally? |
|
@gr2m yeah, working on it. thx for the heads up. I'm guilty of not running the tests locally 😅🧐 |
|
you can also run |
Add test for instanceof
|
@gr2m Done. I had to step away for a little bit. Fixed lint, fixed coverage drop due to the new export. Should be good for another pass. thanks |
|
🎉 This PR is included in version 4.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes types and the error constructor for the error being
thrown when a GraphQL response contains errors. This allows
consumers to easily distinguish between unrelated errors vs.
graphql related errors, and allows for type-guarded access of
the response data / response headers.
Fixes #311