Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove @types/aws-lambda as dependency of this project #332

Open
oscard0m opened this issue Aug 30, 2022 · 0 comments
Open

Remove @types/aws-lambda as dependency of this project #332

oscard0m opened this issue Aug 30, 2022 · 0 comments
Labels
Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
JS

Comments

@oscard0m
Copy link
Member

oscard0m commented Aug 30, 2022 •
edited

To do so, let's remove the middleware entirely from this repository, and release it in an external package, such as @octokit/middleware-aws-lambda-oauth

Originally posted by @gr2m in #331 (comment)

Related links

#330
#283
@ghost ghost added this to Inbox in JS Aug 30, 2022
@oscard0m oscard0m changed the title remove the middleware entirely from this repository, and release it in an external package, such as @octokit/middleware-aws-lambda-oauth Remove aws-lambda as dependency of this project Aug 30, 2022
@oscard0m oscard0m added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Aug 30, 2022
@ghost ghost moved this from Inbox to Maintenance in JS Aug 30, 2022
@oscard0m oscard0m mentioned this issue Aug 30, 2022
Merged
@oscard0m oscard0m changed the title Remove aws-lambda as dependency of this project Remove @types/aws-lambda as dependency of this project Aug 30, 2022
@oscard0m oscard0m mentioned this issue Aug 30, 2022
Closed
@baoshan baoshan mentioned this issue Aug 31, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
No open projects
JS
  
Maintenance
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(middleware): remove aws-lambda handler baoshan/oauth-app.js
1 participant
@oscard0m