Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT]: Allow query.login for GET /api/github/oauth/login #397

Open
1 task done
picchietti opened this issue Mar 7, 2023 · 0 comments
Open
1 task done

[FEAT]: Allow query.login for GET /api/github/oauth/login #397

picchietti opened this issue Mar 7, 2023 · 0 comments
Labels
Status: Needs info Full requirements are not yet known, so implementation should not be started Type: Feature New feature or request
Projects

Comments

@picchietti
Copy link

Describe the need

There is a discrepancy between the getWebFlowAuthorizationUrl options and the params accepted by the login middleware: The login option is not available as a param to the login middleware.

If using the login option is desired then users must use the getWebFlowAuthorizationUrl method instead of the middleware. Is this intentional?

Is login still a valid option to the method or is the documentation outdated?

const { url } = app.getWebFlowAuthorizationUrl({
state: query.state,
scopes: query.scopes ? query.scopes.split(",") : undefined,
allowSignup: query.allowSignup
? query.allowSignup === "true"
: undefined,
redirectUrl: query.redirectUrl,
});

SDK Version

@octokit/oauth-app@4.2.0

API Version

No response

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@picchietti picchietti added Status: Triage This is being looked at and prioritized Type: Feature New feature or request labels Mar 7, 2023
@ghost ghost added this to Features in JS Mar 7, 2023
@kfcampbell kfcampbell added Priority: Normal Status: Needs info Full requirements are not yet known, so implementation should not be started and removed Status: Triage This is being looked at and prioritized labels Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs info Full requirements are not yet known, so implementation should not be started Type: Feature New feature or request
Projects
Status: 🔥 Backlog
JS
  
Features
Development

No branches or pull requests

3 participants