fix: keeps expiresAt with token if present

[baoshan]

When token expiration applies, return values with a token should comes with an expiresAt.

Documentation of below GitHub APIs indicates an expires_at property may show up in the response data:

• check-token
• reset-token
• scope-token

[gr2m]

I'm wondering if we should rename the GitHubAppAuthenticationWithExpiration type to GitHubAppAuthenticationWithRefreshToken in order to make the distinction clear now that we added expiresAt? to GitHubAppAuthentication?

We should however keep the GitHubAppAuthenticationWithExpiration type because other @octokit/ packages now dependon it, but we could mark it as @deprecated, until the next breaking version.

What do you think?

[baoshan]

I @deprecated both GitHubAppAuthentication and GitHubAppAuthenticationWithExpiration (with their original definition untouched) and introduced:

1. GitHubAppAuthenticationWithExpirationEnabled
2. GitHubAppAuthenticationWithExpirationDisabled
3. GitHubAppAuthenticationWithRefreshToken

Once the types defined in different modules are crystallize, can we try to refactor (and unify) them into octokit/types? I’m not familiar with the existing design so I’m not very confident that the PR is consistent with the big picture.

Please let me know if it doesn’t look good.

[gr2m]

Changes look good, thanks a lot!

We do a big revamp of how the types work at https://github.com/octokit/octokit-next.js, I'll make sure to adapt the new naming there once we get to it.

We can update the types at other projects that import them but it's not critical.

[gr2m]

Thanks a lot!

[github-actions]

🎉 This PR is included in version 1.2.5 🎉

The release is available on:

• GitHub release
• npm package (@latest dist-tag)

Your semantic-release bot 📦🚀