Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent status schema components["schemas"]["status"] #178

Closed
gita-vahdatinia opened this issue Feb 8, 2022 · 3 comments
Closed

Inconsistent status schema components["schemas"]["status"] #178

gita-vahdatinia opened this issue Feb 8, 2022 · 3 comments
Labels
Status: Needs info Full requirements are not yet known, so implementation should not be started Status: Stale Used by stalebot to clean house Type: Bug Something isn't working as documented
Projects
JS

Comments

@gita-vahdatinia
Copy link

gita-vahdatinia commented Feb 8, 2022 •
edited

The payload for octokit.repos.createCommitStatus for a status is different than the status response from octokit.repos.listCommitStatusesForRef.
octokit.repos.createCommitStatus is string and octokit.repos.createCommitStatus is 'pending' | 'success' | 'failure' | 'error'. `
@ghost ghost added this to Inbox in JS Feb 8, 2022
@wolfy1339
Copy link
Member

wolfy1339 commented Feb 8, 2022 •
edited

The types are merely a 1:1 compilation of the OpenAPI schema from GitHub at the current time of release.

Currently, the JS octokit modules (including this one), are unmaintained.

You can read more about it in this discussion and this issue in the GitHub docs repo

@wolfy1339 wolfy1339 added Type: Bug Something isn't working as documented Status: Blocked Some technical or requirement is blocking the issue labels Feb 8, 2022
@ghost ghost moved this from Inbox to Blocked in JS Feb 8, 2022
@wolfy1339
Copy link
Member

wolfy1339 commented Aug 15, 2022 •
edited

Hello @gita-codaio,

Can you confirm whether this problem still exists in the latest release?

@wolfy1339 wolfy1339 added Status: Needs info Full requirements are not yet known, so implementation should not be started and removed Status: Blocked Some technical or requirement is blocking the issue labels Aug 19, 2022
@ghost ghost moved this from Blocked to Awaiting response in JS Aug 19, 2022
@wolfy1339 wolfy1339 added the Status: Stale Used by stalebot to clean house label Nov 13, 2022
@ghost ghost moved this from Awaiting response to Bugs in JS Nov 13, 2022
@wolfy1339
Copy link
Member

Closing since there hasn't been any response. If anyone else encounters this issue again, please open a new issue

@wolfy1339 wolfy1339 closed this as not planned Won't fix, can't repro, duplicate, stale Nov 13, 2022
JS automation moved this from Bugs to Done Nov 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Needs info Full requirements are not yet known, so implementation should not be started Status: Stale Used by stalebot to clean house Type: Bug Something isn't working as documented
Projects
No open projects
JS
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wolfy1339 @gita-vahdatinia