Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: BREAKING CHANGES: renames [repository-rule-params-code-scanning-threshold to repository-rule-params-code-scanning-tool, security_alerts to security_alerts_threshold], renames fields[repository-rule-params-code-scanning-threshold.alerts to repository-rule-params-code-scanning-tool.alerts_threshold, repository-rule-params-code-scanning-threshold.security_alerts to repository-rule-params-code-scanning-tool.security_alerts_threshold] #409

Merged
merged 2 commits into from
Apr 5, 2024

Conversation

octokitbot
Copy link
Contributor

Make sure to update the commits so that the merge results in helpful release notes, see Merging the Pull Request & releasing a new version.

In general

  • Avoid breaking changes at all costs
  • If there are no typescript changes, use build: cache as commit message
  • If there are there are only updates, use fix: ...
  • If there are any new additions, use feat: ...
  • If there are breaking changes, keep the previous ones and deprecate them. Only if there is no other way, add BREAKING CHANGE: ... to the commit body (not subject!) to trigger a breaking change.

@octokitbot octokitbot added Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR typescript Relevant to TypeScript users only labels Apr 4, 2024
@nickfloyd nickfloyd changed the title 🚧 OpenAPI types changed feat: BREAKING CHANGES: renames [repository-rule-params-code-scanning-threshold to repository-rule-params-code-scanning-tool, security_alerts to security_alerts_threshold], renames fields[repository-rule-params-code-scanning-threshold.alerts to repository-rule-params-code-scanning-tool.alerts_threshold, repository-rule-params-code-scanning-threshold.security_alerts to repository-rule-params-code-scanning-tool.security_alerts_threshold] Apr 5, 2024
@nickfloyd nickfloyd added the Type: Breaking change Used to note any change that requires a major version bump label Apr 5, 2024
@nickfloyd nickfloyd merged commit 17537ce into main Apr 5, 2024
1 check passed
@nickfloyd nickfloyd deleted the openapi-update branch April 5, 2024 19:41
@octokitbot
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Type: Breaking change Used to note any change that requires a major version bump Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR typescript Relevant to TypeScript users only
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants