Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for pagination in new GET /enterprises/{enterprise}/code-scanning/alerts API #421

Merged
merged 1 commit into from Jul 28, 2022

Conversation

octokitbot
Copy link
Collaborator

If there are any new endpoints, then the code changes will likely required an update of @octokit/types. It should have received a pull request as well, merge & release it first. The @octokit/types should be updated automatically shortly after in this pull request.

Make sure to update the commits so that the merge results in helpful release notes, see Merging the Pull Request & releasing a new version.

In general

  • Avoid breaking changes at all costs
  • If there are no typescript or code changes, use a docs prefix
  • If there are typescript changes but no code changes, use fix(typescript) prefix
  • If there are code changes, use fix if a problem was resolved, feat if new endpoints / parameters were added, and feat(deprecation) if a method was deprecated.

@octokitbot octokitbot added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Jul 22, 2022
@ghost ghost added this to Inbox in JS Jul 22, 2022
@ghost ghost moved this from Inbox to Maintenance in JS Jul 22, 2022
@timrogers timrogers changed the title 🚧 GitHub OpenAPI specifications changed feat: add support for pagination in new GET /enterprises/{enterprise}/code-scanning/alerts API Jul 22, 2022
timrogers
timrogers previously approved these changes Jul 22, 2022
oscard0m
oscard0m previously approved these changes Jul 22, 2022
Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GET /enterprises/{enterprise}/code-scanning/alerts is missing in @octokit/openapi-types. Latest updates failed: https://github.com/octokit/openapi-types.ts/actions/workflows/update.yml

@wolfy1339
Copy link
Member

@octokit/openapi-types should no longer pose problems since octokit/openapi-types.ts#213 was merged.
The update workflow completed successfully octokit/openapi-types.ts#215

@octokitbot octokitbot dismissed stale reviews from oscard0m and timrogers via 6b4bddd July 27, 2022 17:06
@oscard0m oscard0m force-pushed the openapi-update branch 2 times, most recently from 53adfc6 to e7952c6 Compare July 27, 2022 19:04
@oscard0m
Copy link
Member

GET /enterprises/{enterprise}/code-scanning/alerts

Checking my local node_modules/@octokit/openapi-types I see /enterprises/{enterprise}/code-scanning/alerts there.

@oscard0m oscard0m enabled auto-merge (squash) July 27, 2022 19:09
@oscard0m oscard0m merged commit da450cb into master Jul 28, 2022
JS automation moved this from Maintenance to Done Jul 28, 2022
@oscard0m oscard0m deleted the openapi-update branch July 28, 2022 14:58
@github-actions
Copy link
Contributor

🎉 This PR is included in version 3.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
No open projects
JS
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants