Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript): improve response types for octokit.apps.createInstallationAccessToken #319

Merged
merged 1 commit into from Jan 18, 2021

Conversation

octokitbot
Copy link
Collaborator

If there are any new endpoints, then the code changes will likely required an update of @octokit/types. It should have received a pull request as well, merge & release it first. The @octokit/types should be updated automatically shortly after in this pull request.

Make sure to update the commits so that the merge results in helpful release notes, see Merging the Pull Request & releasing a new version.

In general

  • Avoid breaking changes at all costs
  • If there are no typescript or code changes, use a docs prefix
  • If there are typescript changes but no code changes, use fix(typescript) prefix
  • If there are code changes, use fix if a problem was resolved, feat if new endpoints / parameters were added, and feat(deprecation) if a method was deprecated.

@ghost ghost added this to Inbox in JS Jan 18, 2021
@gr2m gr2m changed the title 🚧 GitHub OpenAPI specifications changed fix(typescript): improve response types for octokit.apps.createInstallationAccessToken Jan 18, 2021
@gr2m gr2m merged commit d969566 into master Jan 18, 2021
JS automation moved this from Inbox to Done Jan 18, 2021
@gr2m gr2m deleted the openapi-update branch January 18, 2021 18:32
@github-actions
Copy link
Contributor

🎉 This PR is included in version 4.5.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
JS
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants