Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: many removed/new endpoints #608

Merged
merged 1 commit into from Jan 20, 2023
Merged

feat: many removed/new endpoints #608

merged 1 commit into from Jan 20, 2023

Conversation

wolfy1339
Copy link
Member

BREAKING CHANGE: remove defunct endpoints

This empty commit is due to the fact that #607 was released as a feature release despite it removing endpoints

See octokit/types.ts#500 octokit/plugin-paginate-rest.js#498


Behavior

Before the change?

  • Endpoints were removed in a feature release

After the change?

  • Will trigger a new major version bump

Other information


Additional info

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes (Please add the Type: Breaking change label)
  • No

If Yes, what's the impact:

  • N/A

Pull request type

Please add the corresponding label for change this PR introduces:

  • Bugfix: Type: Bug
  • Feature/model/API additions: Type: Feature
  • Updates to docs or samples: Type: Documentation
  • Dependencies/code cleanup: Type: Maintenance

BREAKING CHANGE: remove defunct endpoints

This empty commit is due to the fact that #607 was released as a feature release despite it removing endpoints
@wolfy1339 wolfy1339 added Type: Bug Something isn't working as documented Priority: High Type: Breaking change Used to note any change that requires a major version bump labels Jan 20, 2023
@ghost ghost added this to Bugs in JS Jan 20, 2023
@wolfy1339
Copy link
Member Author

Once this is merged, I will push a revert to the 6.x branch to trigger a final release without the breaking change

@wolfy1339 wolfy1339 merged commit 2448154 into main Jan 20, 2023
JS automation moved this from Bugs to Done Jan 20, 2023
@wolfy1339 wolfy1339 deleted the major-version-bump branch January 20, 2023 20:24
@github-actions
Copy link
Contributor

🎉 This PR is included in version 7.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Type: Breaking change Used to note any change that requires a major version bump Type: Bug Something isn't working as documented
Projects
Archived in project
JS
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants