Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps): add @octokit/request-error as a runtime dependency #440

Merged
merged 1 commit into from Jun 13, 2023
Merged

fix(deps): add @octokit/request-error as a runtime dependency #440

merged 1 commit into from Jun 13, 2023

Conversation

wolfy1339
Copy link
Member

Resolves #436

Behavior

Before the change?

  • The package @octokit/request-error was being used in this module without it being listed in the dependencies

After the change?

  • @octokit/request-error is now listed in dependencies

Other information

Additional info

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes (Please add the Type: Breaking change label)
  • No

If Yes, what's the impact:

  • N/A

Pull request type

Please add the corresponding label for change this PR introduces:

  • Bugfix: Type: Bug
  • Dependencies/code cleanup: Type: Maintenance

@wolfy1339 wolfy1339 added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Jun 9, 2023
@ghost ghost added this to Maintenance in JS Jun 9, 2023
kfcampbell
kfcampbell approved these changes Jun 13, 2023
View reviewed changes
Copy link
Member

@kfcampbell kfcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@wolfy1339 wolfy1339 merged commit 0396e2d into main Jun 13, 2023
7 checks passed
@wolfy1339 wolfy1339 deleted the fix-missing-deps branch June 13, 2023 18:42
@github-actions
Copy link

🎉 This PR is included in version 5.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kfcampbell kfcampbell kfcampbell approved these changes

@nickfloyd nickfloyd Awaiting requested review from nickfloyd

@gr2m gr2m Awaiting requested review from gr2m

Assignees
No one assigned
Labels
released Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
🧰 Octokit Active
Archived in project
JS
  
Maintenance
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: @octokit/request-error is not listed in dependencies
2 participants
@wolfy1339 @kfcampbell