fix: Do not retry status code 451 by default #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added this to Inbox
in 
|
Test failure looks unrelated to these changes (and it passes locally.) Guessing GitHub Actions was just running a bit slower, causing the timing measured here to be off by 9ms |
451 is returned when a resource has been restricted for legal reasons. Retrying this status needlessly wastes API quota
jahands
force-pushed
the
fix-do-not-retry-451
branch
from
bb5db36
to
ecfdf9c
Compare
|
Kicked the commit to try to get tests to run again |
wolfy1339
approved these changes
Jul 3, 2023
|
🎉 This PR is included in version 5.0.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
451 is returned when a resource has been restricted for legal reasons. Retrying this status needlessly wastes API quota.
Here's an example: https://api.github.com/repos/amusi/Python3
Resolves #448
Behavior
Before the change?
API calls resulting in status code 451 would be retried
*
After the change?
API calls resulting in status code 451 are no longer retried
*
Other information
Additional info
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!
Type: Breaking changelabel)If
Yes, what's the impact:Pull request type
Please add the corresponding label for change this PR introduces:
Type: BugType: FeatureType: DocumentationType: Maintenance