Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: use test_matrix and test jobs #237

Closed
wolfy1339 opened this issue Jul 8, 2022 · 1 comment · Fixed by #238
Closed

ci: use test_matrix and test jobs #237

wolfy1339 opened this issue Jul 8, 2022 · 1 comment · Fixed by #238
Projects
JS

Comments

@wolfy1339
Copy link
Member

Follow up to #236

Ideally we would do a test_matrix step and then a test step that depends on test_matrix, so that for branch protections we can require test independent of the Node versions we are using.

See this for reference: https://github.com/octokit/core.js/blob/393caf31b2e802ea9be59aa84f90d64f98953fdb/.github/workflows/test.yml#L32
@ghost ghost added this to Maintenance in JS Jul 8, 2022
@oscard0m oscard0m mentioned this issue Jul 9, 2022
Merged
@gr2m gr2m closed this as completed in #238 Jul 9, 2022
JS automation moved this from Maintenance to Done Jul 9, 2022
@github-actions
Copy link

🎉 This issue has been resolved in version 3.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
No open projects
JS
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci(test): use test_matrix and test jobs octokit/request-error.js
1 participant
@wolfy1339