Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Typescript] request options autocomplete not working #486

Open
ghost opened this issue Jun 26, 2022 · 3 comments · May be fixed by octokit/types.ts#404
Open

[Typescript] request options autocomplete not working #486

ghost opened this issue Jun 26, 2022 · 3 comments · May be fixed by octokit/types.ts#404
Labels
Type: Bug Something isn't working as documented typescript Relevant to TypeScript users only
Projects
JS

Comments

@ghost
Copy link

ghost commented Jun 26, 2022 •
edited by ghost

After PR #399 that fixed route completion, options are not triggered anymore..

const octokit = new Octokit({ auth: `personal-access-token123` });

const response = await octokit.request(
    "GET /orgs/{org}/repos",
    {
          // the options key (e.g. 'org') has no completion anymore
          org: "octokit",
    }
);
@ghost ghost added the Type: Bug Something isn't working as documented label Jun 26, 2022
@ghost ghost added this to Bugs in JS Jun 26, 2022
@wolfy1339
Copy link
Member

I think you meant to include more information in your issue body, and this is related to #469 (comment)

@wolfy1339 wolfy1339 added the typescript Relevant to TypeScript users only label Jun 26, 2022
@wolfy1339 wolfy1339 changed the title [Typescript] [Typescript] request options autocomplete not working Jun 26, 2022
@ghost
Copy link
Author

ghost commented Jun 26, 2022

Sorry, I miss clicked so it has validated the form

@gr2m
Copy link
Contributor

gr2m commented Jun 26, 2022

Oh no, this is such a rabbit hole :( I thin should revert #399 for now and then create a new issue to address the problem. It seems like a bug introduced by TypeScript, so maybe we can help track that down and try to help get it fixed in TS directly?

@kachick kachick mentioned this issue Jun 27, 2022
Closed
@levenleven levenleven linked a pull request Jun 27, 2022 that will close this issue
Open
This was referenced Sep 6, 2022
Open
Open
@NOUIY NOUIY mentioned this issue Sep 17, 2022
Open
@adamlaska adamlaska mentioned this issue Oct 3, 2022
Open
@NOUIY NOUIY mentioned this issue Oct 15, 2022
Open
@NOUIY NOUIY mentioned this issue Apr 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Something isn't working as documented typescript Relevant to TypeScript users only
Projects
No open projects
JS
  
Bugs
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(RequestInterface): restore catch all overload levenleven/types.ts
2 participants
@gr2m @wolfy1339