[MAINT]: {origin} in asset upload seems dubious

[ggreif]

Describe the need

See https://github.com/octokit/types.ts/blob/main/src/generated/Endpoints.ts#L5211

If I follow to the documentation link https://docs.github.com/rest/reference/repos#upload-a-release-asset
the {origin} path segment is not mentioned at all.

Also there are no other URL templates with such a segment.

SDK Version

No response

API Version

No response

Relevant log output

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

[gr2m]

It's a special case. You can see in the docs that the domain for uploading assets is uploads.github.com, not api.github.com. For GHES it's <GHES origin>/api/uploads I think. But as per the documention, you should

Use the upload_url returned in the response of the Create a release endpoint to upload a release asset.

[ggreif]

Thanks! That clarifies it. The upload_url is passed here:
https://github.com/svenstaro/upload-release-action/blob/master/src/main.ts#L100

[gr2m]

If you set url, you don't need to set a route, it gets overwritten. I think you want to do this

  const uploaded_asset: UploadAssetResp = await octokit.request({
    ...repo(),
    method: 'POST',
    url: release.data.upload_url,
    release_id: release.data.id,
    name: asset_name,
    data: file_bytes,
    headers: {
      'content-type': 'binary/octet-stream',
      'content-length': file_size
    }
  })

The content-length header should be set for you automatically by fetch which is used for requests under the hood

[ggreif]

@gr2m thanks! Is the data: '@' + file,-style specification of the source expected to work? (I didn't succeed to make it work).