From 3ce8aa4b0b2190a252a6512635ffc2996461d5cf Mon Sep 17 00:00:00 2001 From: Octokit Bot Date: Wed, 8 Jun 2022 22:28:54 +0000 Subject: [PATCH 1/4] WIP: Webhooks changed - please review --- README.md | 1 + package-lock.json | 28 ++++++++++++++-------------- package.json | 4 ++-- src/generated/webhook-names.ts | 8 ++++++++ 4 files changed, 25 insertions(+), 16 deletions(-) diff --git a/README.md b/README.md index a9a337ef..5c73266d 100644 --- a/README.md +++ b/README.md @@ -671,6 +671,7 @@ If there are actions for a webhook, events are emitted for both, the webhook nam | [`project`](https://docs.github.com/en/developers/webhooks-and-events/webhooks/webhook-events-and-payloads#project) | `closed`
`created`
`deleted`
`edited`
`reopened` | | [`project_card`](https://docs.github.com/en/developers/webhooks-and-events/webhooks/webhook-events-and-payloads#project_card) | `converted`
`created`
`deleted`
`edited`
`moved` | | [`project_column`](https://docs.github.com/en/developers/webhooks-and-events/webhooks/webhook-events-and-payloads#project_column) | `created`
`deleted`
`edited`
`moved` | +| [`projects_v2_item`](https://docs.github.com/en/developers/webhooks-and-events/webhooks/webhook-events-and-payloads#projects_v_item) | `archived`
`converted`
`created`
`deleted`
`edited`
`reordered`
`restored` | | [`public`](https://docs.github.com/en/developers/webhooks-and-events/webhooks/webhook-events-and-payloads#public) | | | [`pull_request`](https://docs.github.com/en/developers/webhooks-and-events/webhooks/webhook-events-and-payloads#pull_request) | `assigned`
`auto_merge_disabled`
`auto_merge_enabled`
`closed`
`converted_to_draft`
`edited`
`labeled`
`locked`
`opened`
`ready_for_review`
`reopened`
`review_request_removed`
`review_requested`
`synchronize`
`unassigned`
`unlabeled`
`unlocked` | | [`pull_request_review`](https://docs.github.com/en/developers/webhooks-and-events/webhooks/webhook-events-and-payloads#pull_request_review) | `dismissed`
`edited`
`submitted` | diff --git a/package-lock.json b/package-lock.json index 22ad4890..21eed99a 100644 --- a/package-lock.json +++ b/package-lock.json @@ -11,13 +11,13 @@ "dependencies": { "@octokit/request-error": "^2.0.2", "@octokit/webhooks-methods": "^2.0.0", - "@octokit/webhooks-types": "5.6.0", + "@octokit/webhooks-types": "5.7.0", "aggregate-error": "^3.1.0" }, "devDependencies": { "@jest/types": "^27.0.0", "@octokit/tsconfig": "^1.0.1", - "@octokit/webhooks-schemas": "5.6.0", + "@octokit/webhooks-schemas": "5.7.0", "@pika/pack": "^0.5.0", "@pika/plugin-build-node": "^0.9.2", "@pika/plugin-build-web": "^0.9.2", @@ -2228,15 +2228,15 @@ "integrity": "sha512-35cfQ4YWlnZnmZKmIxlGPUPLtbkF8lr/A/1Sk1eC0ddLMwQN06dOuLc+dI3YLQS+T+MoNt3DIQ0NynwgKPilig==" }, "node_modules/@octokit/webhooks-schemas": { - "version": "5.6.0", - "resolved": "https://registry.npmjs.org/@octokit/webhooks-schemas/-/webhooks-schemas-5.6.0.tgz", - "integrity": "sha512-xIZcNABoU0/JRmnQYIlr1KluOUEYH59WYy4cPfurp1K4oglzChhZwY6RVFz8sZpMqd+/Jh4+rXItKMgVvReN8w==", + "version": "5.7.0", + "resolved": "https://registry.npmjs.org/@octokit/webhooks-schemas/-/webhooks-schemas-5.7.0.tgz", + "integrity": "sha512-bDPt1QUPg67hsPcuiz7Ye9Forz487DCESTfICv1tgjOj5v5lr3PxJEDfQqgmxSJygb4MeBaFUhNFXU8MWbpYwA==", "dev": true }, "node_modules/@octokit/webhooks-types": { - "version": "5.6.0", - "resolved": "https://registry.npmjs.org/@octokit/webhooks-types/-/webhooks-types-5.6.0.tgz", - "integrity": "sha512-y3MqE6N6Ksg1+YV0sXVpW2WP7Y24h7rUp2hDJuzoqWdKGr7owmRDyHC72INwfCYNzura/vsNPXvc6Xbfp4wGGw==" + "version": "5.7.0", + "resolved": "https://registry.npmjs.org/@octokit/webhooks-types/-/webhooks-types-5.7.0.tgz", + "integrity": "sha512-dvRcrFCiCfYKV/0lF4djZwyXB0KL4ptovc1p17tixYWcB60aOtuHFZlbMG/19g3E914SkA+5FCxnucAYqAJspw==" }, "node_modules/@pika/babel-plugin-esm-import-rewrite": { "version": "0.6.1", @@ -17322,15 +17322,15 @@ "integrity": "sha512-35cfQ4YWlnZnmZKmIxlGPUPLtbkF8lr/A/1Sk1eC0ddLMwQN06dOuLc+dI3YLQS+T+MoNt3DIQ0NynwgKPilig==" }, "@octokit/webhooks-schemas": { - "version": "5.6.0", - "resolved": "https://registry.npmjs.org/@octokit/webhooks-schemas/-/webhooks-schemas-5.6.0.tgz", - "integrity": "sha512-xIZcNABoU0/JRmnQYIlr1KluOUEYH59WYy4cPfurp1K4oglzChhZwY6RVFz8sZpMqd+/Jh4+rXItKMgVvReN8w==", + "version": "5.7.0", + "resolved": "https://registry.npmjs.org/@octokit/webhooks-schemas/-/webhooks-schemas-5.7.0.tgz", + "integrity": "sha512-bDPt1QUPg67hsPcuiz7Ye9Forz487DCESTfICv1tgjOj5v5lr3PxJEDfQqgmxSJygb4MeBaFUhNFXU8MWbpYwA==", "dev": true }, "@octokit/webhooks-types": { - "version": "5.6.0", - "resolved": "https://registry.npmjs.org/@octokit/webhooks-types/-/webhooks-types-5.6.0.tgz", - "integrity": "sha512-y3MqE6N6Ksg1+YV0sXVpW2WP7Y24h7rUp2hDJuzoqWdKGr7owmRDyHC72INwfCYNzura/vsNPXvc6Xbfp4wGGw==" + "version": "5.7.0", + "resolved": "https://registry.npmjs.org/@octokit/webhooks-types/-/webhooks-types-5.7.0.tgz", + "integrity": "sha512-dvRcrFCiCfYKV/0lF4djZwyXB0KL4ptovc1p17tixYWcB60aOtuHFZlbMG/19g3E914SkA+5FCxnucAYqAJspw==" }, "@pika/babel-plugin-esm-import-rewrite": { "version": "0.6.1", diff --git a/package.json b/package.json index ac89d6f6..6402efa7 100644 --- a/package.json +++ b/package.json @@ -20,13 +20,13 @@ "dependencies": { "@octokit/request-error": "^2.0.2", "@octokit/webhooks-methods": "^2.0.0", - "@octokit/webhooks-types": "5.6.0", + "@octokit/webhooks-types": "5.7.0", "aggregate-error": "^3.1.0" }, "devDependencies": { "@jest/types": "^27.0.0", "@octokit/tsconfig": "^1.0.1", - "@octokit/webhooks-schemas": "5.6.0", + "@octokit/webhooks-schemas": "5.7.0", "@pika/pack": "^0.5.0", "@pika/plugin-build-node": "^0.9.2", "@pika/plugin-build-web": "^0.9.2", diff --git a/src/generated/webhook-names.ts b/src/generated/webhook-names.ts index 1b3d5fd3..56951444 100644 --- a/src/generated/webhook-names.ts +++ b/src/generated/webhook-names.ts @@ -141,6 +141,14 @@ export const emitterEventNames = [ "project_column.deleted", "project_column.edited", "project_column.moved", + "projects_v2_item", + "projects_v2_item.archived", + "projects_v2_item.converted", + "projects_v2_item.created", + "projects_v2_item.deleted", + "projects_v2_item.edited", + "projects_v2_item.reordered", + "projects_v2_item.restored", "public", "pull_request", "pull_request.assigned", From 7efb9a802f92686b197d246a797aba68fd086560 Mon Sep 17 00:00:00 2001 From: Octokit Bot Date: Wed, 8 Jun 2022 23:01:46 +0000 Subject: [PATCH 2/4] WIP: Webhooks changed - please review --- package-lock.json | 28 ++++++++++++++-------------- package.json | 4 ++-- 2 files changed, 16 insertions(+), 16 deletions(-) diff --git a/package-lock.json b/package-lock.json index 21eed99a..84e6203b 100644 --- a/package-lock.json +++ b/package-lock.json @@ -11,13 +11,13 @@ "dependencies": { "@octokit/request-error": "^2.0.2", "@octokit/webhooks-methods": "^2.0.0", - "@octokit/webhooks-types": "5.7.0", + "@octokit/webhooks-types": "5.7.1", "aggregate-error": "^3.1.0" }, "devDependencies": { "@jest/types": "^27.0.0", "@octokit/tsconfig": "^1.0.1", - "@octokit/webhooks-schemas": "5.7.0", + "@octokit/webhooks-schemas": "5.7.1", "@pika/pack": "^0.5.0", "@pika/plugin-build-node": "^0.9.2", "@pika/plugin-build-web": "^0.9.2", @@ -2228,15 +2228,15 @@ "integrity": "sha512-35cfQ4YWlnZnmZKmIxlGPUPLtbkF8lr/A/1Sk1eC0ddLMwQN06dOuLc+dI3YLQS+T+MoNt3DIQ0NynwgKPilig==" }, "node_modules/@octokit/webhooks-schemas": { - "version": "5.7.0", - "resolved": "https://registry.npmjs.org/@octokit/webhooks-schemas/-/webhooks-schemas-5.7.0.tgz", - "integrity": "sha512-bDPt1QUPg67hsPcuiz7Ye9Forz487DCESTfICv1tgjOj5v5lr3PxJEDfQqgmxSJygb4MeBaFUhNFXU8MWbpYwA==", + "version": "5.7.1", + "resolved": "https://registry.npmjs.org/@octokit/webhooks-schemas/-/webhooks-schemas-5.7.1.tgz", + "integrity": "sha512-YEHdtU5KQZZdqRevyAGD5lV+Qg6aF0QJVKaxDNPP6YLmkDicqj9nbscpKqXIsvy3Jf8tvVOYIjiZKDK161Dj0Q==", "dev": true }, "node_modules/@octokit/webhooks-types": { - "version": "5.7.0", - "resolved": "https://registry.npmjs.org/@octokit/webhooks-types/-/webhooks-types-5.7.0.tgz", - "integrity": "sha512-dvRcrFCiCfYKV/0lF4djZwyXB0KL4ptovc1p17tixYWcB60aOtuHFZlbMG/19g3E914SkA+5FCxnucAYqAJspw==" + "version": "5.7.1", + "resolved": "https://registry.npmjs.org/@octokit/webhooks-types/-/webhooks-types-5.7.1.tgz", + "integrity": "sha512-zabCzfWvvquxDzj1lU7GhJQteACGfGXnHfROJD4A7LKhRjlkaggoSkE5cWQJJ6nW2t/UI51dSFrEA+A4mhqfPw==" }, "node_modules/@pika/babel-plugin-esm-import-rewrite": { "version": "0.6.1", @@ -17322,15 +17322,15 @@ "integrity": "sha512-35cfQ4YWlnZnmZKmIxlGPUPLtbkF8lr/A/1Sk1eC0ddLMwQN06dOuLc+dI3YLQS+T+MoNt3DIQ0NynwgKPilig==" }, "@octokit/webhooks-schemas": { - "version": "5.7.0", - "resolved": "https://registry.npmjs.org/@octokit/webhooks-schemas/-/webhooks-schemas-5.7.0.tgz", - "integrity": "sha512-bDPt1QUPg67hsPcuiz7Ye9Forz487DCESTfICv1tgjOj5v5lr3PxJEDfQqgmxSJygb4MeBaFUhNFXU8MWbpYwA==", + "version": "5.7.1", + "resolved": "https://registry.npmjs.org/@octokit/webhooks-schemas/-/webhooks-schemas-5.7.1.tgz", + "integrity": "sha512-YEHdtU5KQZZdqRevyAGD5lV+Qg6aF0QJVKaxDNPP6YLmkDicqj9nbscpKqXIsvy3Jf8tvVOYIjiZKDK161Dj0Q==", "dev": true }, "@octokit/webhooks-types": { - "version": "5.7.0", - "resolved": "https://registry.npmjs.org/@octokit/webhooks-types/-/webhooks-types-5.7.0.tgz", - "integrity": "sha512-dvRcrFCiCfYKV/0lF4djZwyXB0KL4ptovc1p17tixYWcB60aOtuHFZlbMG/19g3E914SkA+5FCxnucAYqAJspw==" + "version": "5.7.1", + "resolved": "https://registry.npmjs.org/@octokit/webhooks-types/-/webhooks-types-5.7.1.tgz", + "integrity": "sha512-zabCzfWvvquxDzj1lU7GhJQteACGfGXnHfROJD4A7LKhRjlkaggoSkE5cWQJJ6nW2t/UI51dSFrEA+A4mhqfPw==" }, "@pika/babel-plugin-esm-import-rewrite": { "version": "0.6.1", diff --git a/package.json b/package.json index 6402efa7..0c59814e 100644 --- a/package.json +++ b/package.json @@ -20,13 +20,13 @@ "dependencies": { "@octokit/request-error": "^2.0.2", "@octokit/webhooks-methods": "^2.0.0", - "@octokit/webhooks-types": "5.7.0", + "@octokit/webhooks-types": "5.7.1", "aggregate-error": "^3.1.0" }, "devDependencies": { "@jest/types": "^27.0.0", "@octokit/tsconfig": "^1.0.1", - "@octokit/webhooks-schemas": "5.7.0", + "@octokit/webhooks-schemas": "5.7.1", "@pika/pack": "^0.5.0", "@pika/plugin-build-node": "^0.9.2", "@pika/plugin-build-web": "^0.9.2", From 42171ba16baf13ac16a44d5b425428ca59241fbc Mon Sep 17 00:00:00 2001 From: wolfy1339 Date: Wed, 8 Jun 2022 21:35:58 -0400 Subject: [PATCH 3/4] ci: allow numbers in webhooks docs URLs This is due to the fact that some webhooks have been created with numbers in their name, example `projects_v2_item` --- scripts/generate-types.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/generate-types.ts b/scripts/generate-types.ts index fa268d97..536ee538 100755 --- a/scripts/generate-types.ts +++ b/scripts/generate-types.ts @@ -85,7 +85,7 @@ const generateTypeScriptFile = (name: string, contents: string[]) => { const asCode = (str: string): string => `\`${str}\``; const asLink = (event: string): string => { const link = `https://docs.github.com/en/developers/webhooks-and-events/webhooks/webhook-events-and-payloads#${event.replace( - /[^a-z_]/g, + /[^a-z_0-9]/g, "" )}`; From aa94258d1e8bf107d077a063470026b48c0d8326 Mon Sep 17 00:00:00 2001 From: wolfy1339 Date: Wed, 8 Jun 2022 21:36:18 -0400 Subject: [PATCH 4/4] docs(README): fix link to `project_v2_item` docs --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 5c73266d..915d9283 100644 --- a/README.md +++ b/README.md @@ -671,7 +671,7 @@ If there are actions for a webhook, events are emitted for both, the webhook nam | [`project`](https://docs.github.com/en/developers/webhooks-and-events/webhooks/webhook-events-and-payloads#project) | `closed`
`created`
`deleted`
`edited`
`reopened` | | [`project_card`](https://docs.github.com/en/developers/webhooks-and-events/webhooks/webhook-events-and-payloads#project_card) | `converted`
`created`
`deleted`
`edited`
`moved` | | [`project_column`](https://docs.github.com/en/developers/webhooks-and-events/webhooks/webhook-events-and-payloads#project_column) | `created`
`deleted`
`edited`
`moved` | -| [`projects_v2_item`](https://docs.github.com/en/developers/webhooks-and-events/webhooks/webhook-events-and-payloads#projects_v_item) | `archived`
`converted`
`created`
`deleted`
`edited`
`reordered`
`restored` | +| [`projects_v2_item`](https://docs.github.com/en/developers/webhooks-and-events/webhooks/webhook-events-and-payloads#projects_v2_item) | `archived`
`converted`
`created`
`deleted`
`edited`
`reordered`
`restored` | | [`public`](https://docs.github.com/en/developers/webhooks-and-events/webhooks/webhook-events-and-payloads#public) | | | [`pull_request`](https://docs.github.com/en/developers/webhooks-and-events/webhooks/webhook-events-and-payloads#pull_request) | `assigned`
`auto_merge_disabled`
`auto_merge_enabled`
`closed`
`converted_to_draft`
`edited`
`labeled`
`locked`
`opened`
`ready_for_review`
`reopened`
`review_request_removed`
`review_requested`
`synchronize`
`unassigned`
`unlabeled`
`unlocked` | | [`pull_request_review`](https://docs.github.com/en/developers/webhooks-and-events/webhooks/webhook-events-and-payloads#pull_request_review) | `dismissed`
`edited`
`submitted` |