Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new pull_request_review_thread event #594

Merged
merged 5 commits into from Nov 23, 2021
Merged

Conversation

wolfy1339
Copy link
Member

Fixes #593

This event is currently not documented in the GitHub docs

@wolfy1339 wolfy1339 added the Type: Feature New feature or request label Nov 23, 2021
@ghost ghost added this to Features in JS Nov 23, 2021
Copy link
Member

@G-Rath G-Rath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ugh thank you! I'd been meaning to do this for a while but hadn't gotten the time :(

@wolfy1339 wolfy1339 enabled auto-merge (squash) November 23, 2021 22:05
@wolfy1339 wolfy1339 merged commit e455c0b into master Nov 23, 2021
@wolfy1339 wolfy1339 deleted the new-event-review-thread branch November 23, 2021 22:06
JS automation moved this from Features to Done Nov 23, 2021
@wolfy1339
Copy link
Member Author

Ah shucks!

Why isn't the Do types need to be regenerated? check required?

@octokitbot
Copy link
Collaborator

🎉 This PR is included in version 4.17.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@G-Rath
Copy link
Member

G-Rath commented Nov 23, 2021

hmm I thought it was?

@G-Rath
Copy link
Member

G-Rath commented Nov 23, 2021

oh you mean for merging - idk about that 😅

wolfy1339 added a commit that referenced this pull request Nov 23, 2021
wolfy1339 added a commit that referenced this pull request Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New feature or request
Projects
No open projects
JS
  
Done
Development

Successfully merging this pull request may close these issues.

pull_request_review_thread types are missing
3 participants