Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes object can be undefined #688

Closed
LightningStairs opened this issue Aug 9, 2022 · 2 comments · Fixed by #690
Closed

Changes object can be undefined #688

LightningStairs opened this issue Aug 9, 2022 · 2 comments · Fixed by #690
Labels
Type: Bug Something isn't working as documented
Projects

Comments

@LightningStairs
Copy link

We we imported the BranchProtectionRuleEditedEvent recently and we came across an issue. The changes object can be undefined but the Type definition doesn't allow for it to be undefined. To replicate this, go to a repo's branch protection settings and it save without changing any of the settings. This fires off a BranchProtectionRuleEditedEvent without the changes object.

changes: {
authorized_actors_only?: {
from: boolean;
};
authorized_actor_names?: {
from: string[];
};
required_status_checks?: {
from: string[];
};
};

@ghost ghost added this to Inbox in JS Aug 9, 2022
@wolfy1339 wolfy1339 added the Type: Bug Something isn't working as documented label Aug 9, 2022
@ghost ghost moved this from Inbox to Bugs in JS Aug 9, 2022
@wolfy1339
Copy link
Member

Can you confirm wether this is for GitHub.com and not GitHub.AE or GitHub Enterprise?
Please provide an example payload that demonstrates this behaviour

JS automation moved this from Bugs to Done Aug 9, 2022
wolfy1339 added a commit that referenced this issue Aug 9, 2022
…dited`, add missing keys to `changes` property in `branch_protection_rule#edited`, new `blocking` permission for apps (#690)

Fixes #688
Fixes part of #689
@octokitbot
Copy link
Collaborator

🎉 This issue has been resolved in version 6.3.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working as documented
Projects
No open projects
JS
  
Done
3 participants