Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenBSD ln and install do not have -v flag #1943

Open
dontlaugh opened this issue Apr 21, 2024 · 4 comments
Open

OpenBSD ln and install do not have -v flag #1943

dontlaugh opened this issue Apr 21, 2024 · 4 comments

Comments

@dontlaugh
Copy link
Contributor

System Details

  • OpenBSD 7.5 GENERIC.MP#138 arm64
  • oils-for-unix release tarball 0.21.0

The Problem

Neither ln nor the install utility have a -v flag on OpenBSD.

This had consequences for the ./install script, for example here:

https://github.com/oilshell/oil/blob/master/install#L93

And also in the generated build script _build/oils.sh, down at the bottom. Ninja generates it in ShellFunctions

https://github.com/oilshell/oil/blob/master/build/ninja_main.py#L229

@andychu
Copy link
Contributor

andychu commented Apr 22, 2024

Thanks for the report! This shouldn't be too hard to fix

andychu pushed a commit that referenced this issue Apr 26, 2024
Replace with our own logging.

This is issue #1943.
andychu pushed a commit that referenced this issue Apr 26, 2024
Adjust appearance.

Part of issue #1943
@andychu
Copy link
Contributor

andychu commented Apr 26, 2024

This is now fixed, you can test a tarball from the CI

http://travis-ci.oilshell.org/github-jobs/6794/cpp-tarball.wwz/_release/oils-for-unix.tar

Thanks for testing!

@dontlaugh
Copy link
Contributor Author

Success!

% doas ./install 
  + install -d /usr/local/bin
  + install _bin/cxx-opt-sh/oils-for-unix.stripped /usr/local/bin/oils-for-unix
    Installed /usr/local/bin/oils-for-unix
    Created 'osh' symlink
    Created 'ysh' symlink
  + install -d /usr/local/share/man/man1
  + install -m 644 doc/osh.1 /usr/local/share/man/man1
    Installed man page

@andychu
Copy link
Contributor

andychu commented Apr 29, 2024

I have a script that collects these for release notes, so it's OK to leave it open for now

thanks for testing!

@andychu andychu reopened this Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants