Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement bind builtin #339

Open
andychu opened this issue Jun 15, 2019 · 4 comments · May be fixed by #349
Open

Implement bind builtin #339

andychu opened this issue Jun 15, 2019 · 4 comments · May be fixed by #349

Comments

@andychu
Copy link
Contributor

andychu commented Jun 15, 2019

From #322

I don't know how this works ... hopefully it isn't a big time sink ...

@andychu
Copy link
Contributor Author

andychu commented Jun 15, 2019

I labeled "good first issue" since I will take anything that passes a test :) Doesn't have to be complete.

I think it's basically passing through arguments to GNU readline, which is readline_mod if you grep the code, but I'm not sure.

mrshu added a commit to mrshu/oil that referenced this issue Jun 19, 2019
* Add a simple, introductory version of the buildtin `bind` command that
  just passes configuration options to `readline`.

* Fixes oilshell#339.

Signed-off-by: mr.Shu <mr@shu.io>
mrshu added a commit to mrshu/oil that referenced this issue Jun 19, 2019
* Add a simple, introductory version of the buildtin `bind` command that
  just passes configuration options to `readline`.

* Fixes oilshell#339.

Signed-off-by: mr.Shu <mr@shu.io>
@mrshu mrshu linked a pull request Jun 19, 2019 that will close this issue
@bugcrazy
Copy link

@andychu
Copy link
Contributor Author

andychu commented Nov 30, 2021

Hm that might help, but for the foreseeable future the interactive shell is off my personal TODO list. So I hope that someone makes a big effort in this direction, including understanding the bind builtin :)

The last section of the last blog post links to a comment that gives color on this:

http://www.oilshell.org/blog/2021/11/release-0.9.4.html#links

@Melkor333
Copy link
Collaborator

btw. the bash init script for atuin fails due to missing bind implementation (and also missing bash_versinfo, which is easily fixable):

bind -x '"\C-r": __atuin_history'
bind -x '"\e[A": __atuin_history --shell-up-key-binding'
bind -x '"\eOA": __atuin_history --shell-up-key-binding'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants