Error thrown when running lint-staged from a child directory

[jdanil]

Description

After upgrading to v11.2.1, lint-staged exits with the following error.

× Current directory is not a git directory!

I am using lint-staged in a monorepo, so each package runs the command (as advised here https://github.com/okonet/lint-staged#how-to-use-lint-staged-in-a-multi-package-monorepo), rather than being run from the repository root directory.

Steps to reproduce

1. run lint-staged in a child directory of the git repository's root.

Debug Logs

expand to view

{
  '*': [
    'eslint --fix',
    'prettier --write'
  ]
}

Environment

• OS: Windows 10
• Node.js: 14.18.0
• lint-staged: 11.2.1

[iiroj]

Hello,

does this happen with 1.12.0? If not then it's a bug introduced in PR #1026.

we might be missing a test case, so if you can get it to reproduce I'll be happy to fix it an add a test!

[tkalmar]

The culprit is indeed my cygwin fix. Sorry for any inconvinience.

[github-actions]

🎉 This issue has been resolved in version 11.2.2 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[jdanil]

Hi, thanks for the quick response! I gave 11.2.2 a try today, and I believe I'm still facing the same issue.

I did a bit more digging, and I believe the issue for me is occurring in determineGitDir. Specifically cwd.substring(0, cwd.lastIndexOf(relativeDir)). This appears to be returning an empty string.

I have a public repo you can reproduce it on https://github.com/jdanil/skunkworks. Just run yarn precommit in any non-root workspace.

[iiroj]

Thanks @jdanil, let me reopen the ticket.

EDIT: This seems to be a Windows-specific issue since I can't replicate it on macOS:

~/git/skunkworks/applications/app master
❯ yarn precommit
→ No staged files found.

[aleksanderfret]

I tried 11.2.2 today. And I also got "Current directory is not a git directory!" regardless of whether I ran the script in the root or in individual packages.
(Windows 10)

[iiroj]

@aleksanderfret any help from Windows users is appreciated! I could also revert the changes of 11.2.1 and 11.2.2 (and release 11.2.3) until the original Cygwin issue is fixed in a new PR without breaking non-cygwin Windows environments.

What do you think, @okonet?

[tkalmar]

Meh tested on all (for me) available windows plattforms. Worked on cygwin, but not git-bash or git-cmd. The error has been found an corrected in #1029

[jdanil]

That did the trick! Thanks @tkalmar and @iiroj 🙏

[github-actions]

🎉 This issue has been resolved in version 11.3.0-beta.2 🎉

The release is available on:

• npm package (@beta dist-tag)
• GitHub release

Your semantic-release bot 📦🚀