fix: revert back to cosmiconfig from lilconfig
#1035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 04529e2.
|
Ping @okonet, what do you think? |
Codecov Report
@@ Coverage Diff @@
## master #1035 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 20 20
Lines 656 654 -2
Branches 149 149
=========================================
- Hits 656 654 -2
Continue to review full report at Codecov.
|
okonet
approved these changes
Oct 26, 2021
|
🎉 This PR is included in version 11.2.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 11.3.0-beta.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts #981 and #1033, the latter of which was a hotfix to the first. This change was only made to decrease the size of lint-staged's node modules, but instead caused lots of errors. I think it's best to go back, because I don't have the capacity to figure out what's wrong with
lilconfig, andcosmiconfigworked fine.This hopefully fixes #1034, and relates to #1032.