Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: convert to native ESM module #1038

Merged
merged 12 commits into from Nov 13, 2021
Merged

feat: convert to native ESM module #1038

merged 12 commits into from Nov 13, 2021

Conversation

iiroj
Copy link
Member

@iiroj iiroj commented Nov 6, 2021

BREAKING CHANGE: lint-staged is now a pure ESM module, and thus
requires Node.js version ^12.20.0 || ^14.13.1 || >=16.0.0.

To update your Node.js integration, please use:

// const lintStaged = require('lint-staged')
import lintStaged from 'lint-staged'

jest.config.js Show resolved Hide resolved
lib/chunkFiles.js Show resolved Hide resolved
lib/chunkFiles.js Show resolved Hide resolved
@iiroj iiroj requested a review from okonet November 6, 2021 11:59
@iiroj
Copy link
Member Author

iiroj commented Nov 6, 2021

What do you think, @okonet?

lib/execGit.js Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Nov 6, 2021

Codecov Report

Merging #1038 (557ddf3) into master (64e4364) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1038   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           20        20           
  Lines          654       577   -77     
  Branches       149       156    +7     
=========================================
- Hits           654       577   -77     
Impacted Files Coverage Δ
lib/chunkFiles.js 100.00% <100.00%> (ø)
lib/execGit.js 100.00% <100.00%> (ø)
lib/figures.js 100.00% <100.00%> (ø)
lib/file.js 100.00% <100.00%> (ø)
lib/generateTasks.js 100.00% <100.00%> (ø)
lib/getRenderer.js 100.00% <100.00%> (ø)
lib/getStagedFiles.js 100.00% <100.00%> (ø)
lib/gitWorkflow.js 100.00% <100.00%> (ø)
lib/index.js 100.00% <100.00%> (ø)
lib/makeCmdTasks.js 100.00% <100.00%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64e4364...557ddf3. Read the comment docs.

jimmywarting
jimmywarting previously approved these changes Nov 13, 2021
Copy link

@jimmywarting jimmywarting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

okonet
okonet previously approved these changes Nov 13, 2021
Copy link
Collaborator

@okonet okonet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@iiroj
Copy link
Member Author

iiroj commented Nov 13, 2021

@okonet should we merge Windows Actions #833 first?

@okonet
Copy link
Collaborator

okonet commented Nov 13, 2021

Sure go ahead!

@iiroj
Copy link
Member Author

iiroj commented Nov 13, 2021

@okonet I rebased, updated deps, and enabled a few ESLint rules to automatically sort imports.

@iiroj iiroj requested a review from okonet November 13, 2021 10:18
@iiroj iiroj merged commit 7240f61 into master Nov 13, 2021
@iiroj iiroj deleted the convert-to-esm branch November 13, 2021 18:32
@github-actions
Copy link
Contributor

🎉 This PR is included in version 12.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

3 participants