fix: node-please-upgrade usage #575
Conversation
Codecov Report
@@ Coverage Diff @@
## master #575 +/- ##
=======================================
Coverage 98.14% 98.14%
=======================================
Files 13 13
Lines 378 378
Branches 52 52
=======================================
Hits 371 371
Misses 7 7Continue to review full report at Codecov.
|
package.json
Outdated
| @@ -10,6 +10,9 @@ | |||
| "Suhas Karanth <sudo.suhas@gmail.com>" | |||
| ], | |||
| "bin": "index.js", | |||
| "engines": { | |||
| "node": ">=8.6.0" | |||
There was a problem hiding this comment.
That’s was intentional not to have it here since it would break CIs with lower versions of Node installed without a particular reason. I’m on my mobile so I can’t search for the issue but please look for it.
There was a problem hiding this comment.
I see, too bad we can't have optional dev deps 😞
We should at least pass the name to node-please-upgrade to avoid broken message.
There was a problem hiding this comment.
Yes that’s what I’m keen to merge. Could you please update the PR? Thanks!
Before: `undefined requires at least version 8.6.0 of Node, please upgrade` After: `lint-staged requires at least version 8.6.0 of Node, please upgrade`
julien-f
changed the title
|
Hmm could you please check why is CI failing now? |
|
I think it's because I pushed too quickly and GitHub/Travis mixed things up a bit, because the tests passed: https://travis-ci.org/okonet/lint-staged/pull_requests |
|
Thanks for working on this! |
|
🎉 This PR is included in version 8.1.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Before:
undefined requires at least version 8.6.0 of Node, please upgradeAfter:
lint-staged requires at least version 8.6.0 of Node, please upgrade