Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update lodash version #578

Merged
merged 2 commits into from Feb 14, 2019
Merged

chore: update lodash version #578

merged 2 commits into from Feb 14, 2019

Conversation

josiahwiebe
Copy link
Contributor

The lodash version in lint-staged is vulnerable to prototype pollution.

https://nodesecurity.io/advisories/782

This PR just updates the lodash version.

@codecov
Copy link

codecov bot commented Feb 13, 2019

Codecov Report

Merging #578 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #578   +/-   ##
=======================================
  Coverage   98.13%   98.13%           
=======================================
  Files          13       13           
  Lines         376      376           
  Branches       52       52           
=======================================
  Hits          369      369           
  Misses          7        7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 138fbc7...f5822f5. Read the comment docs.

@okonet
Copy link
Collaborator

okonet commented Feb 14, 2019

The vulnerability applies to versions prior the one we’re using but I think it’s still good to update to the latest. Thanks!

@okonet okonet merged commit 0be88a0 into lint-staged:master Feb 14, 2019
@okonet
Copy link
Collaborator

okonet commented Feb 14, 2019

🎉 This PR is included in version 8.1.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@josiahwiebe
Copy link
Contributor Author

Sounds good! I was just doing an npm audit and this cropped up so I thought I’d submit a PR.

Thanks so much for this awesome package! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

2 participants