Resolves [High] Security Vulnerability in js-yaml #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simply just updates the package.json to bump up cosmiconfig and re-runs yarn
Codecov Report
@@ Coverage Diff @@
## master #615 +/- ##
=======================================
Coverage 98.13% 98.13%
=======================================
Files 13 13
Lines 376 376
Branches 52 52
=======================================
Hits 369 369
Misses 7 7Continue to review full report at Codecov.
|
okonet
approved these changes
May 15, 2019
|
Thanks! |
|
🎉 This PR is included in version 8.1.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #600,
js-yamlhas a high-level security vulnerability, andcosmiconfigdepends on it. In this PR, I bump up the version ofcosmiconfigto 5.2.0 (which should introduce no breaking changes), and regenerate theyarn.lockfile. Now, runningyarn auditno longer yields any high severity security errors (though there is one moderate found inlodash, and many low-level security vulnerabilities as children ofjest).Please let me know if there's anything else I should do!