Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overriding env variable to find git dir #629

Merged

Conversation

carnun
Copy link
Contributor

@carnun carnun commented Jun 12, 2019

A potential, but slightly more hacky, fix for #627

@codecov
Copy link

codecov bot commented Jun 12, 2019

Codecov Report

Merging #629 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #629      +/-   ##
==========================================
+ Coverage   98.15%   98.15%   +<.01%     
==========================================
  Files          14       14              
  Lines         379      380       +1     
  Branches       53       53              
==========================================
+ Hits          372      373       +1     
  Misses          7        7
Impacted Files Coverage Δ
src/resolveGitDir.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bffef73...c179a31. Read the comment docs.

Copy link
Member

@iiroj iiroj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ping @okonet; see discussion on #627 (comment). I don’t want to merge this myself since I am on a holiday away from the computer. Looks fine to me though, and has been tested to resolve the issue by @carnun.

@carnun
Copy link
Contributor Author

carnun commented Jun 12, 2019

Please refer to comments made here - #627 (comment)

@vadimka123
Copy link

Updating git to latest version (2.21.0) resolve issue
Not need this changes

@okonet okonet merged commit 5892455 into lint-staged:master Jun 13, 2019
@okonet
Copy link
Collaborator

okonet commented Jun 13, 2019

🎉 This PR is included in version 8.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

4 participants