fix: always resolve real git config dir location if .git is a file #784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #784 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 13 13
Lines 484 485 +1
Branches 108 106 -2
=====================================
+ Hits 484 485 +1
Continue to review full report at Codecov.
|
okonet
approved these changes
Jan 30, 2020
|
🎉 This PR is included in version 10.0.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #783 by always checking if the the
.gitdirectory is actually file, and then resolves the real directory location by reading the file.This works for both submodules and added worktrees.