Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconcile MFA mechanisms #140

Open
jmhale opened this issue Oct 3, 2020 · 0 comments
Open

Reconcile MFA mechanisms #140

jmhale opened this issue Oct 3, 2020 · 0 comments

Comments

@jmhale
Copy link
Member

jmhale commented Oct 3, 2020

Since the support for per-app MFA was included, two separate mechanisms for handling MFA has begun to emerge. They're doing very similar things, but in different ways.

I refactored the Okta auth code to pull each of these out into their own classes in order to help reason about what each of them are doing, but the ultimate goal should be to combine these into one of the existing or a new class and use that for both login flows.

Currently, we have support for different factors depending on if the user is authenticating to the base org or an app. Okta doesn't differentiate between the two on what factors are allowed, so neither should we.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant