-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
more storybook and test add #358
Comments
I am willing to rewrite the first 5 components stories as a start! However, I have a suggestion, what if we remove |
I'll take a look at this, create a new pr and import it. |
What do you mean by "import it", which part are you referring to?. Also, should I create a PR for each component story or all together? |
|
@Cr0zy07 After sending the popper pr, you will see how it will work. Please Popper pr wait |
I can take the toolbar and the hover-card. |
@Cr0zy07 The 3 structures for each component should be collected in 1 pr, each component should be pr separately. Why should we do all 3 together in one pr? We can see bugs while writing the stories, so we need to fix the code. Also, since the code will change, I think it is best to finish the tests in the same place. I sent popper pr and merged them, I updated the texts here, please check. |
@mturkoz93 added. Thank you ❤️ |
I can contribute to progress bar |
Thank you. I added. |
The following areas need to be checked and tested again. Missing areas need to be repaired
Radix Storybook
We Example Storybook This is the best example and the old style of writing needs to be converted to this format.
Please post a comment if you would like to take part. and select components
3 step single pr may also be available.
Step 1 - Components Storybook
Example packages
Step 2 - Components Test
Example packages
Vue Test Docs
component is create
tests
folder and move test or create test. You can integrate some of the stories and add them to your tests.Step 3 Props and Types one file
props.ts
addExample packages
The text was updated successfully, but these errors were encountered: