Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more storybook and test add #358

Open
39 of 60 tasks
productdevbook opened this issue Sep 14, 2023 · 10 comments
Open
39 of 60 tasks

more storybook and test add #358

productdevbook opened this issue Sep 14, 2023 · 10 comments

Comments

@productdevbook
Copy link
Member

productdevbook commented Sep 14, 2023

The following areas need to be checked and tested again. Missing areas need to be repaired

Radix Storybook

We Example Storybook This is the best example and the old style of writing needs to be converted to this format.

Please post a comment if you would like to take part. and select components

3 step single pr may also be available.

Step 1 - Components Storybook

Example packages

Step 2 - Components Test

Example packages
Vue Test Docs

component is create tests folder and move test or create test. You can integrate some of the stories and add them to your tests.

Step 3 Props and Types one file props.ts add

Example packages

@productdevbook productdevbook changed the title storybook and test add more storybook and test add Sep 14, 2023
@Cr0zy07
Copy link
Collaborator

Cr0zy07 commented Sep 14, 2023

I am willing to rewrite the first 5 components stories as a start!

However, I have a suggestion, what if we remove TailwindCSS and PostCSS from the devDeps and just use plain CSS?

@productdevbook
Copy link
Member Author

productdevbook commented Sep 14, 2023

However, I have a suggestion, what if we remove TailwindCSS and PostCSS from the devDeps and just use plain CSS?

I'll take a look at this, create a new pr and import it.

@Cr0zy07
Copy link
Collaborator

Cr0zy07 commented Sep 14, 2023

However, I have a suggestion, what if we remove TailwindCSS and PostCSS from the devDeps and just use plain CSS?

I'll take a look at this, create a new pr and import it.

What do you mean by "import it", which part are you referring to?. Also, should I create a PR for each component story or all together?

@productdevbook
Copy link
Member Author

import it this: #359

@productdevbook
Copy link
Member Author

Also, should I create a PR for each component story or all together?

@Cr0zy07 After sending the popper pr, you will see how it will work. Please Popper pr wait

@mustafa60x
Copy link
Contributor

I can take the toolbar and the hover-card.

@productdevbook
Copy link
Member Author

@Cr0zy07 The 3 structures for each component should be collected in 1 pr, each component should be pr separately.

Why should we do all 3 together in one pr?

We can see bugs while writing the stories, so we need to fix the code. Also, since the code will change, I think it is best to finish the tests in the same place.

I sent popper pr and merged them, I updated the texts here, please check.

@productdevbook
Copy link
Member Author

@mturkoz93 added. Thank you ❤️

@mohi0
Copy link

mohi0 commented Nov 5, 2023

I can contribute to progress bar

@productdevbook
Copy link
Member Author

I can contribute to progress bar

Thank you. I added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants