Skip to content
This repository has been archived by the owner on Sep 16, 2019. It is now read-only.

Gulp task for pot generation #1356

Open
derweili opened this issue Jan 28, 2019 · 4 comments
Open

Gulp task for pot generation #1356

derweili opened this issue Jan 28, 2019 · 4 comments
Milestone

Comments

@derweili
Copy link
Collaborator

We should implement a process for generating a pot file.

I think we can implement this by using this package
https://github.com/rasmusbe/gulp-wp-pot

@derweili
Copy link
Collaborator Author

derweili commented Feb 4, 2019

I implemented a solution in 94e4852

checkout the pot-task branch

Unfortunately the gulp-wp-pot requires node > 8 which does not comply with our current requirements (node > 6.11).

I think this should be implemented after the whole build process has beeen refactored.

@kLOsk
Copy link
Collaborator

kLOsk commented Feb 4, 2019 via email

@derweili
Copy link
Collaborator Author

derweili commented Feb 5, 2019

@kLOsk I would prefer ES6 over ES5.

What are the issuees with ES6?

@kLOsk
Copy link
Collaborator

kLOsk commented Feb 7, 2019

It's just that the official Gulp documentation has all examples in ES5 and it's somewhat difficult to follow our gulp file if you are unaware of the differences. We should make a note in the gulpfile that it's using ES6 and point to some ES6 docs I think.

@derweili derweili added this to the v2.11.0 milestone Apr 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants